{Keyvault} az keyvault key/secret/certificate/storage/role: Get endpoint from vault server#26711
Draft
{Keyvault} az keyvault key/secret/certificate/storage/role: Get endpoint from vault server#26711
az keyvault key/secret/certificate/storage/role: Get endpoint from vault server#26711Conversation
|
Hi @evelyn-ys, |
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
ghost
added
the
Collaborator
|
Keyvault |
ghost
requested a review
from 
evelyn-ys
modified the milestones:
August 2023 (2023-09-05),
September 2023 (2023-09-26)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az keyvault key/secret/certificate/storage/roleall data plane commands
Description
Keyvault data plane clients all require
vault_urlparameter. When customer provide--vault-name, we used to construct thevault_urlwith name and suffix in the format off'https://{vault_name}{cli_ctx.cloud.suffixes.keyvault_dns}'. The suffix differs for different clouds:azure-cli/src/azure-cli-core/azure/cli/core/cloud.py
Line 322 in d4b27cb
azure-cli/src/azure-cli-core/azure/cli/core/cloud.py
Line 356 in d4b27cb
azure-cli/src/azure-cli-core/azure/cli/core/cloud.py
Line 388 in d4b27cb
azure-cli/src/azure-cli-core/azure/cli/core/cloud.py
Line 415 in d4b27cb
But in the near feature, keyvault is going to support DNS partitioning. By that time, the suffix should be like
.vault.z23.azure.net, which means the endpoint should contain zone info.So instead of construct the
vault_urlby ourselves, we need to get the endpoint from vault server instead.Testing Guide
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.