Skip to content

{Keyvault} az keyvault key/secret/certificate/storage/role: Get endpoint from vault server #26711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
evelyn-ys wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

{Keyvault} az keyvault key/secret/certificate/storage/role: Get endpoint from vault server #26711

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e7eeb4
first try with valuts.list
evelyn-ys Jun 19, 2023
4be4eaf
try with resources.list
evelyn-ys Jun 20, 2023
1291bf6
fix
evelyn-ys Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/azure-cli/azure/cli/command_modules/keyvault/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,23 @@ def _get_base_url_type(cli_ctx, service):
suffix = ''

def base_url_type(name):
if service == 'vault':
filter = "resourceType eq 'Microsoft.KeyVault/vaults' and name eq '{}'".format(name)
vaults = []
try:
resource_client = get_mgmt_service_client(cli_ctx, ResourceType.MGMT_RESOURCE_RESOURCES).resources
vaults = list(resource_client.list(filter=filter))
except Exception as ex:
logger.debug(f"Failed to get vault with filter {filter}: {ex}")
return 'https://{}{}'.format(name, suffix)

if vaults:
from msrestazure.tools import parse_resource_id
id_comps = parse_resource_id(vaults[0].id)
vault_client = get_mgmt_service_client(cli_ctx, ResourceType.MGMT_KEYVAULT).vaults
vault = vault_client.get(resource_group_name=id_comps['resource_group'], vault_name=name)
logger.debug(f"Get vault uri from vault properties {vault.properties}.")
return vault.properties.vault_uri
return 'https://{}{}'.format(name, suffix)

return base_url_type
Expand Down
Loading