{ACS} aks nodepool update: Update help message#27179
Open
MaxMelcher wants to merge 1 commit intoAzure:devfrom
Open
{ACS} aks nodepool update: Update help message#27179MaxMelcher wants to merge 1 commit intoAzure:devfrom
aks nodepool update: Update help message#27179MaxMelcher wants to merge 1 commit intoAzure:devfrom
Conversation
az aks nodepool update --node-taints
MaxMelcher
requested review from
andyliuliming,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
FumingZhang and
yonzhan
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
FumingZhang
approved these changes
Aug 17, 2023
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
LGTM
please update PR title to something like
{AKS} az aks nodepool update: Update help message of option --node-taints
jiasli
reviewed
Aug 17, 2023
| - name: --node-taints | ||
| type: string | ||
| short-summary: The node taints for the node pool. You can update the existing node taint of a nodepool or create a new node taint for a nodepool. Pass the empty string `""` to remove all taints. | ||
| short-summary: The node taints for the node pool. You can update the existing node taint of a nodepool or create a new node taint for a nodepool. Pass the empty string `""` (or `'""'` in PowerShell) to remove all taints. |
Member
There was a problem hiding this comment.
This is a PowerShell issue (#15529) and many arguments have similar help messages:
I am not sure if it is a good idea to mention it every time an empty string is passed to an argument, as this is often overlooked.
Contributor
There was a problem hiding this comment.
Good point. For the general issue of PowerShell, we may consider adding it to a centralized document
zhoxing-ms
changed the title
aks nodepool update: Update help message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove --node-taints in powershell does not work if you do not escape the double quotes.
You need to scape the double quotes with single quotes and this should be highlighted in the docs.
Related command
az aks nodepool update --node-taints
Description
The provided example does not work in PowerShell and the error is confusing.
Testing Guide
az aks nodepool update --resource-group --cluster-name --name --node-taints ""
results in: argument --node-taints: expected one argument
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.