[ARM] az bicep: Install correct bicep for apple M1, M2 and respect bicep.use_binary_from_path in all commands#27194
Open
colbylwilliams wants to merge 4 commits intoAzure:devfrom
Open
[ARM] az bicep: Install correct bicep for apple M1, M2 and respect bicep.use_binary_from_path in all commands#27194colbylwilliams wants to merge 4 commits intoAzure:devfrom
az bicep: Install correct bicep for apple M1, M2 and respect bicep.use_binary_from_path in all commands#27194colbylwilliams wants to merge 4 commits intoAzure:devfrom
Conversation
colbylwilliams
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
❌AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
Collaborator
|
Resource |
microsoft-github-policy-service
bot
added
the
ARM
zhoxing-ms
changed the title
az bicep: Install correct bicep for apple M1, M2 and respect bicep.use_binary_from_path in all commands
Contributor
|
@colbylwilliams Please resolve these CI issues |
zhoxing-ms
modified the milestones:
August 2023 (2023-09-05),
September 2023 (2023-09-26)
Contributor
|
@shenglol Could you please help take a look at this PR? |
Member
Author
|
@zhoxing-ms @shenglol can you please help resolve the CI issues. Unfortunately, I'm having trouble finding time to commit to this. |
Contributor
|
I am so sorry, because we have been super busy with the top priority project Azure Copilot recently, and the end of September is the Mid-Autumn Festival holiday in China, I am afraid we do not have enough time and bandwidth to review this PR. |
zhoxing-ms
modified the milestones:
September 2023 (2023-09-26),
October 2023 (2023-11-15)❗ Breaking change release ❗
Member
Author
@zhoxing-ms I don't think this is acceptable. Users on Apple computers with M1 or M2, cannot use the built-in bicep functionality of the Azure CLI. Without this fix, az cli attempts to install the wrong architecture bicep binaries, and throws errors. The (failing) workaround would be to manually install correct (arm64) bicep binaries and tell az cli to use those instead using These issues prevent all users on Apple M1 and M2 from using azure cli + bicep. |
Contributor
|
Add @yanzhudd to help take a look at this PR~ |
Contributor
|
@colbylwilliams Could you please resolve these conflicts? |
zhoxing-ms
modified the milestones:
October 2023 (2023-11-14)❗ Breaking change release ❗,
November 2023 (2023-12-05)
zhoxing-ms
modified the milestones:
November 2023 (2023-12-05),
December 2023 (2024-01-02)
zhoxing-ms
modified the milestones:
December 2023 (2024-01-09),
January 2024 (2024-02-06)
zhoxing-ms
modified the milestones:
January 2024 (2024-02-06),
February 2024 (2024-03-05)
Member
Author
|
@zhoxing-ms please review and merge. Conflicts have been resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
The commands above and almost all other
az bicep ..commands callensure_bicep_installation(cmd.cli_ctx)which doesn't respect thebicep.use_binary_from_pathand installs a new the bicep executable the.azure/binregardless ifbicep.use_binary_from_path=true.This is annoying, but the wrong archetecure was being selected for osx arm machines, resulting in
az deployment group|sub createand allaz bicep xxcommands failing with:Testing Guide
See screenshot.
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.