{Synapse} az synapse workspace update: Add support for public-network-access#27601
Open
{Synapse} az synapse workspace update: Add support for public-network-access#27601
az synapse workspace update: Add support for public-network-access#27601Conversation
❌AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
October 2023 (2023-11-15)❗ Breaking change release ❗ milestone
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| synapse workspace update | cmd synapse workspace update added parameter public_network_access |
microsoft-github-policy-service
bot
requested review from
AllyW,
kairu-ms,
necusjz and
yonzhan
Collaborator
|
Synapse |
microsoft-github-policy-service
bot
added
customer-reported
microsoft-github-policy-service
bot
added
the
Network
Closed
yonzhan
modified the milestones:
October 2023 (2023-11-14)❗ Breaking change release ❗,
November 2023 (2023-12-05)
Contributor
Author
|
Hi @jsntcy , @evelyn-ys , any news on this PR please ? Thanks and have a nice day ! |
jsntcy
reviewed
Nov 10, 2023
Member
|
Please add test to cover this change. |
Contributor
Author
Member
There are already many tests in |
…rk-access This adds support for enabling/disabling public network access to the synapse workspace Signed-off-by: Frank Villaro-Dixon <frank.villarodixon@merkle.com>
Contributor
Author
|
Hi @jsntcy The tests have been added. For some unknown error, they fail on some environment with an |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
The error is because you forgot to upload recording file (test_workspace_update_network_access.yaml) for new added test. |
Contributor
Author
|
Hi @jsntcy I'd appreciate if you (aka Microsoft) could create the recording, as I don't have the means to do it myself. Hopefully this can me done and the MR merged. |
yonzhan
modified the milestones:
November 2023 (2023-12-05),
December 2023 (2024-01-02)
|
Thanks for putting this together! Any idea when we can expect this to be merged? It would be very useful. |
Contributor
Author
|
Sadly on my end I can no longer work on this. Most of the work is done,just need the recordings..
Cheers
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az synapse workspace update
Description
This adds support for enabling/disabling public network access to the synapse workspace
Testing Guide
az synapse workspace update --public-network-access true/false
History Notes
[Synapse]
az synapse workspace: Add support for public-network-accessThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.