[ACR] Add new command to check if specific blob is available to pull from registry#27676
Open
[ACR] Add new command to check if specific blob is available to pull from registry#27676
Conversation
❌AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
October 2023 (2023-11-14)❗ Breaking change release ❗ milestone
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| acr check-health | cmd acr check-health added parameter image |
||
| acr check-health | cmd acr check-health added parameter password |
||
| acr check-health | cmd acr check-health added parameter resource_group_name |
||
| acr check-health | cmd acr check-health added parameter username |
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
Collaborator
|
ACR |
microsoft-github-policy-service
bot
added
Auto-Assign
mabenedi
reviewed
Oct 25, 2023
mabenedi
reviewed
Oct 25, 2023
zhoxing-ms
reviewed
Nov 6, 2023
zhoxing-ms
reviewed
Nov 6, 2023
Contributor
|
Please address this CI issues |
Contributor
|
@SakoPak Please note that we are launching the release for this sprint this week. Please resolve all comments and conflicts by Tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 12-05) |
Contributor
Author
This PR can wait until next sprint as it's still in progress, thank you for the heads up. |
yonzhan
modified the milestones:
October 2023 (2023-11-14)❗ Breaking change release ❗,
November 2023 (2023-12-05)
zhoxing-ms
modified the milestones:
November 2023 (2023-12-05),
December 2023 (2024-01-02)
rosanch
suggested changes
Nov 29, 2023
Contributor
rosanch
left a comment
rosanch
left a comment
There was a problem hiding this comment.
Overall looks good, I left some comments, please do not resolve questions. I'll do after reading the response.
Thanks
estebanreyl
reviewed
Dec 15, 2023
estebanreyl
left a comment
estebanreyl
left a comment
There was a problem hiding this comment.
Added a few comments, mostly on edge cases to consider, overall lgtm
| # If manifest is not a Docker Manifest List, find the smallest blob in the given single manifest | ||
| smallest_blob = min(manifest['layers'], key=lambda layer: layer['size']) | ||
|
|
||
| smallest_digest = smallest_blob['digest'] |
There was a problem hiding this comment.
One edge case to account for here is that smallest_blob could be empty, this is because manifests with no layers and Manifest lists with no sub-manifests are also technically allowed. In that situation you might be able to pull the manifest as if it is a regular blob (haven't tried it but it should work) or error and ask the user to use a different image.
Contributor
Author
There was a problem hiding this comment.
ok that's a great point, I will factor in this edge case and have it pull the manifest like a regular blob, thanks!
Contributor
|
@SakoPak Could you please resolve these CI issues? |
zhoxing-ms
modified the milestones:
December 2023 (2024-01-09),
January 2024 (2024-02-06)
zhoxing-ms
modified the milestones:
January 2024 (2024-02-06),
February 2024 (2024-03-05)
Member
|
@SakoPak is this still needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
az acr check-health --name myRegistry --image hello-world@sha256@abc123Testing Guide
az acr check-health -n MyRegistry --image hello-world@sha256:abc123az acr check-health -n MyRegistry -t hello-world:latestHistory Notes
[ACR]
az acr check-health --name --image: Add new command to check if blobs in given image can be pulled from registryThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.