Conversation
koudaiii
requested review from
jsntcy,
kairu-ms,
necusjz and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
network |
microsoft-github-policy-service
bot
added
the
Network
koudaiii
changed the title
az network application-gateway http-listener create Update help message for --frontend-port argumentaz network application-gateway [listener | http-listener\ create Update help message for --frontend-port argument
koudaiii
changed the title
az network application-gateway [listener | http-listener\ create Update help message for --frontend-port argumentaz network application-gateway [listener | http-listener] create Update help message for --frontend-port argument
koudaiii
changed the title
az network application-gateway [listener | http-listener] create Update help message for --frontend-port argumentaz network application-gateway [listener | http-listener] create Update help message for --frontend-port argument
Member
Author
I edited the title. |
Member
|
Yes, but these files are generated. Means it cannot be modified directly, unless it'll be overwritten by the next generation. You can leverage such codegen tool https://github.com/Azure/aaz-dev-tools to apply the above changes. :) |
Member
Author
|
Thank you for your message! I appreciate your guidance. I’ll give it a try and apply the changes using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureSummary
This Pull Request updates the help message for the
--frontend-portoption in theaz network application-gateway http-listener createcommand. The previous message, "Name or ID of the frontend port.", led to some confusion as it could be interpreted as asking for the port number or a TCP name. There have been issues raised due to this misunderstanding.ref. Command "az network application-gateway http-listener create" does not work. #16567
Changes
The help message for
--frontend-porthas been clarified to explicitly state that it is not asking for the port number. The new message is: "This is NOT for the port number. Please input the Resource Name or ID of the frontend port, which can be found using 'az network application-gateway frontend-port list'."Impact
This change will help users understand what is expected for the
--frontend-portoption and prevent future misunderstandings. 😄This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.