[ACR] OnPrem: Connected-registry create: Mode default value changed to readOnly#28807
Merged
zhoxing-ms merged 4 commits intoAzure:devfrom Apr 23, 2024
Merged
[ACR] OnPrem: Connected-registry create: Mode default value changed to readOnly#28807zhoxing-ms merged 4 commits intoAzure:devfrom
zhoxing-ms merged 4 commits intoAzure:devfrom
Conversation
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
May 2024 (2024-05-21)❗ Breaking change release ❗ milestone
❌AzureCLI-BreakingChangeTest
|
Collaborator
|
ACR |
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
rosanch
changed the title
zhoxing-ms
modified the milestones:
May 2024 (2024-05-21)❗ Breaking change release ❗,
April 2024 (2024-04-30)
Contributor
|
@rosanch Could you please re-record some tests related to this PR change? Such as |
Contributor
Author
|
Changes in PR test are precisely to keep the testing behavior unchanged with the default mode property change. |
zhoxing-ms
approved these changes
Apr 23, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az acr connected-registry create
Description
Minor updates on ACR connected registry create:
Testing Guide
History Notes
[ACR] BREAKING CHANGE:
az acr connected-registry create: Mode default value change from ReadWrite to ReadOnly[ACR]
az acr connected-registry create: If data-endpoint disabled ask for confirmation to enable it instead of throwing an errorThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.