[Service Fabric] add sf cluster update command #4328#29908
Open
mwesigwaguma wants to merge 23 commits intoAzure:devfrom
Open
[Service Fabric] add sf cluster update command #4328#29908mwesigwaguma wants to merge 23 commits intoAzure:devfrom
mwesigwaguma wants to merge 23 commits intoAzure:devfrom
Conversation
mwesigwaguma
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
|
Collaborator
|
ServiceFabric |
microsoft-github-policy-service
bot
added
Service Fabric
Member
please add description of the changes in this pr here |
a-santamaria
suggested changes
Sep 18, 2024
src/azure-cli/azure/cli/command_modules/servicefabric/custom.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/servicefabric/custom.py
Outdated
Show resolved
Hide resolved
Contributor
|
Please note that Azure CLI will have a code freeze for the upcoming release on 09/24/2024 10:00 UTC. If you want to catch this release train, please address the comments and CI issues ASAP. Otherwise, it has to be postponed to next sprint (11-05). |
mwesigwaguma
changed the title
mwesigwaguma
changed the title
zhoxing-ms
modified the milestones:
September 2024 (2024-10-08),
October 2024 (2024-11-05)
Contributor
Author
removed breaking change file |
Contributor
|
Actually, my suggestion is to restore the breaking change file b1bfe8a, as it will not cause a real breaking change to the user, but will only notify users with the deprecation information of the parameters through warning logs |
Contributor
|
|
zhoxing-ms
modified the milestones:
January 2025 (2025-01-14),
February 2025 (2025-02-11)
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
@mwesigwaguma please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Contributor
|
Please reply with above information. |
Contributor
|
please note that Azure CLI will freeze the code on 02/25/2025 10:00 UTC for the upcoming release. If you want to catch this release train, please resolve the comments ASAP, otherwise this PR has to be postponed to next sprint. |
zhoxing-ms
approved these changes
Feb 24, 2025
Contributor
|
Please take a look at this comment #29908 (comment) |
Contributor
|
@mwesigwaguma The breaking change window on May sprint is approaching. If you want to release some real breaking change in this breaking change sprint, please follow the deprecation process first cc @ReaNAiveD |
Contributor
|
please note that Azure CLI will have a code freeze on 04/21/2025 07:00 UTC for the upcoming release. Please address the comments ASAP, otherwise it has to be postponed to next sprint (05-19). |
Contributor
|
please resolve the code conflicts. |
yanzhudd
modified the milestones:
May 2025 (2025-05-06),
Build 2025 (2025-05-19)❗ Breaking change release ❗
Contributor
|
Any update? |
zhoxing-ms
modified the milestones:
Build 2025 (2025-05-19)❗ Breaking change release ❗,
June 2025 (2025-06-03)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
sf cluster upgrade-type
sf cluster setting
sf cluster durability
f cluster reliability update
sf cluster setting remove
sf cluster setting set
sf cluster upgrade-type set
Description
The commands groups and commands above are being deprecated and moved under one command sf cluster update
Testing Guide
History Notes
[Service Fabric]
az sf cluster upgrade-type set: Deprecate command. Please useaz sf cluster updatecommand[Service Fabric]
az sf cluster durability: Deprecate command. Please useaz sf cluster updatecommand[Service Fabric]
az sf cluster reliability update: Deprecate command. Please useaz sf cluster updatecommand[Service Fabric]
az sf cluster setting remove: Deprecate command. Please useaz sf cluster updatecommand[Service Fabric]
az sf cluster setting set: Deprecate command. Please useaz sf cluster updatecommandThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.