Skip to content

{App Service} Fix: #20625: az webapp config appsettings set: Fix changing a slot setting to a non-setting fails #30985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seligj95 wants to merge 6 commits into from
Closed

{App Service} Fix: #20625: az webapp config appsettings set: Fix changing a slot setting to a non-setting fails #30985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7795181
fix
seligj95 Mar 7, 2025
e58ed81
remove whitespace
seligj95 Mar 7, 2025
6919c06
format
seligj95 Mar 7, 2025
e9683f1
format
seligj95 Mar 7, 2025
a628e90
Merge branch 'dev' of https://github.com/Azure/azure-cli into 20625
seligj95 Mar 11, 2025
aff64aa
test
seligj95 Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/azure-cli/azure/cli/command_modules/appservice/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,13 @@ def update_app_settings(cmd, resource_group_name, name, settings=None, slot=None
app_settings = _generic_site_operation(cmd.cli_ctx, resource_group_name, name,
'list_application_settings', slot)
result, slot_result = {}, {}

# First, delete any existing app settings with the given names
# Addresses https://github.com/Azure/azure-cli/issues/20625
app_setting_to_delete = [s.split('=', 1)[0] for s in settings + slot_settings]
delete_app_settings(cmd, resource_group_name, name, app_setting_to_delete, slot)

# Now, process and add the new app settings
# pylint: disable=too-many-nested-blocks
for src, dest, setting_type in [(settings, result, "Settings"), (slot_settings, slot_result, "SlotSettings")]:
for s in src:
Expand All @@ -526,13 +533,14 @@ def update_app_settings(cmd, resource_group_name, name, settings=None, slot=None
except CLIError:
setting_name, value = s.split('=', 1)
dest[setting_name] = value
if setting_type == "SlotSettings":
slot_result[setting_name] = True
result.update(dest)

for setting_name, value in result.items():
app_settings.properties[setting_name] = value
client = web_client_factory(cmd.cli_ctx)


# TODO: Centauri currently return wrong payload for update appsettings, remove this once backend has the fix.
if is_centauri_functionapp(cmd, resource_group_name, name):
update_application_settings_polling(cmd, resource_group_name, name, app_settings, slot, client)
Expand Down Expand Up @@ -2545,6 +2553,12 @@ def update_connection_strings(cmd, resource_group_name, name, connection_string_
conn_strings = _generic_site_operation(cmd.cli_ctx, resource_group_name, name,
'list_connection_strings', slot)

# First, delete any existing app settings with the given names
# Addresses https://github.com/Azure/azure-cli/issues/20625
connection_strings_to_delete = [s['name'] for s in settings + sticky_slot_settings]
delete_connection_strings(cmd, resource_group_name, name, connection_strings_to_delete, slot)

# Now, process and add the new connection strings
for name_value_type in settings + sticky_slot_settings:
# split at the first '=', connection string should not have '=' in the name
conn_strings.properties[name_value_type['name']] = ConnStringValueTypePair(value=name_value_type['value'],
Expand Down
Loading
Loading