Skip to content

[RDBMS] az postgres flexible-server fabric-mirroring: BUG FIX, Space separate list of databases was only picking up first name #31000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evelyn-ys merged 11 commits into from
Mar 12, 2025
Merged

[RDBMS] az postgres flexible-server fabric-mirroring: BUG FIX, Space separate list of databases was only picking up first name #31000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ee1192c
add to ignore
nasc17 Feb 24, 2025
d9d34d4
Merge pull request #5 from nasc17/nasc/gitUpdates
nasc17 Feb 24, 2025
6c0e048
Merge branch 'Azure:dev' into dev2
nasc17 Mar 4, 2025
6370088
Fix bug when updating cmk geo
nasc17 Mar 4, 2025
7f19801
Revert "add to ignore"
nasc17 Mar 4, 2025
4857a1a
Merge branch 'Azure:dev' into dev2
nasc17 Mar 7, 2025
50e8d48
Merge branch 'dev2' of https://github.com/nasc17/azure-cli into dev2
nasc17 Mar 7, 2025
3b1d20b
Updates to not create password if pasword is disabled
nasc17 Mar 10, 2025
c0c36b5
Revert "Updates to not create password if pasword is disabled"
nasc17 Mar 11, 2025
2e0117c
Merge branch 'Azure:dev' into dev2
nasc17 Mar 11, 2025
18ce69d
bug fix for fabric mirroring
nasc17 Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1537,7 +1537,7 @@ def flexible_server_fabric_mirroring_start(cmd, client, resource_group_name, ser
# disable fabric mirroring on HA server
raise CLIError("Fabric mirroring is not supported on servers with high availability enabled.")

databases = ','.join(database_names[0].split())
databases = ','.join(database_names)
user_confirmation("Are you sure you want to prepare and enable your server" +
" '{0}' in resource group '{1}' for mirroring of databases '{2}'.".format(server_name, resource_group_name, databases) +
" This requires restart.", yes=yes)
Expand All @@ -1546,10 +1546,6 @@ def flexible_server_fabric_mirroring_start(cmd, client, resource_group_name, ser
logger.warning('Enabling system assigned managed identity on the server.')
flexible_server_identity_update(cmd, flexible_servers_client, resource_group_name, server_name, 'Enabled')

logger.warning('Restarting server.')
parameters = postgresql_flexibleservers.models.RestartParameter(restart_with_failover=False)
resolve_poller(flexible_servers_client.begin_restart(resource_group_name, server_name, parameters), cmd.cli_ctx, 'PostgreSQL Server Restart')

logger.warning('Updating necessary server parameters.')
source = "user-override"
configuration_name = "azure.fabric_mirror_enabled"
Expand Down Expand Up @@ -1593,7 +1589,7 @@ def flexible_server_fabric_mirroring_update_databases(cmd, client, resource_grou
# disable fabric mirroring on HA server
raise CLIError("Fabric mirroring is not supported on servers with high availability enabled.")

databases = ','.join(database_names[0].split())
databases = ','.join(database_names)
user_confirmation("Are you sure for server '{0}' in resource group '{1}' you want to update the databases being mirrored to be '{2}'"
.format(server_name, resource_group_name, databases), yes=yes)

Expand Down
Loading