{Compute} az vm list-skus: Migrate to AAZ#31024
Merged
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
the
Compute
yanzhudd
reviewed
Mar 14, 2025
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
reviewed
Mar 17, 2025
| if restriction.type == 'Zone' and not ( | ||
| set(sku_info.location_info[0].zones or []) - set(restriction.restriction_info.zones or [])): | ||
| if restriction['type'] == 'Zone' and not ( | ||
| set(sku_info['location_info'][0].get('zones', [])) - set(restriction['restriction_info'].get('zones', []))): |
Contributor
There was a problem hiding this comment.
There may be one case where "zones" is in the dictionary but the value is None
Suggested change
| set(sku_info['location_info'][0].get('zones', [])) - set(restriction['restriction_info'].get('zones', []))): | |
| set(sku_info['location_info'][0].get('zones', []) or []) - set(restriction['restriction_info'].get('zones', []) or [])): |
yanzhudd
reviewed
Mar 17, 2025
| if restriction.type == 'Location' and ( | ||
| sku_info.location_info[0].location in (restriction.restriction_info.locations or [])): | ||
| if restriction['type'] == 'Location' and ( | ||
| sku_info['location_info'][0]['location'] in (restriction['restriction_info'].get('locations', []))): |
Contributor
There was a problem hiding this comment.
Suggested change
| sku_info['location_info'][0]['location'] in (restriction['restriction_info'].get('locations', []))): | |
| sku_info['location_info'][0]['location'] in (restriction['restriction_info'].get('locations', []) or [])): |
yanzhudd
reviewed
Mar 17, 2025
| if restriction.type == 'Zone' and not ( | ||
| set(sku_info.location_info[0].zones or []) - set(restriction.restriction_info.zones or [])): | ||
| if restriction['type'] == 'Zone' and not ( | ||
| set(sku_info['location_info'][0].get('zones', [])) - set(restriction['restriction_info'].get('zones', []))): |
Contributor
There was a problem hiding this comment.
Suggested change
| set(sku_info['location_info'][0].get('zones', [])) - set(restriction['restriction_info'].get('zones', []))): | |
| set(sku_info['location_info'][0].get('zones', []) or []) - set(restriction['restriction_info'].get('zones', []) or [])): |
yanzhudd
reviewed
Mar 17, 2025
yanzhudd
previously approved these changes
Mar 17, 2025
cxznmhdcxz
force-pushed
the
vm-list-skus-migrate
branch
from
766da12 to
70e236b
Compare
yanzhudd
approved these changes
Mar 18, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vm list-skusDescription
Azure/aaz#714
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.