Skip to content

{MYSQL} Remove parameter restriction for --high-availability and add breaking change annoucement #31102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evelyn-ys merged 3 commits into from
Mar 24, 2025
Merged

{MYSQL} Remove parameter restriction for --high-availability and add breaking change annoucement #31102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
413d08d
update
linyudoa Mar 21, 2025
3a2a0ba
fix style
linyudoa Mar 24, 2025
cf8410b
fix pylint
linyudoa Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/azure-cli/azure/cli/command_modules/mysql/_breaking_change.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# --------------------------------------------------------------------------------------------
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------
from azure.cli.core.breaking_change import register_logic_breaking_change

register_logic_breaking_change('mysql flexible-server create', 'Update the validator',
detail='the argument `--high-availability` will no longer accept value `SameZone` for '
'new servers created in Business-Critical service tier '
'if the region supports multiple zones.')
register_logic_breaking_change('mysql flexible-server update', 'Update the validator',
detail='the argument `--high-availability` will no longer accept value `SameZone` for '
'new servers created in Business-Critical service tier '
'if the region supports multiple zones.')
6 changes: 1 addition & 5 deletions src/azure-cli/azure/cli/command_modules/mysql/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from azure.cli.core.util import CLIError, sdk_no_wait, user_confirmation, run_cmd
from azure.cli.core.local_context import ALL
from azure.mgmt.mysqlflexibleservers import models
from azure.cli.core.azclierror import ClientRequestError, RequiredArgumentMissingError, ArgumentUsageError, InvalidArgumentValueError, ValidationError
from azure.cli.core.azclierror import ClientRequestError, RequiredArgumentMissingError, InvalidArgumentValueError, ValidationError
from ._client_factory import get_mysql_flexible_management_client, cf_mysql_flexible_firewall_rules, cf_mysql_flexible_db, \
cf_mysql_check_resource_availability, cf_mysql_check_resource_availability_without_location, cf_mysql_flexible_config, \
cf_mysql_flexible_servers, cf_mysql_flexible_replica, cf_mysql_flexible_adadmin, cf_mysql_flexible_private_dns_zone_suffix_operations, cf_mysql_servers, \
Expand Down Expand Up @@ -1175,10 +1175,6 @@ def server_delete_func(cmd, client, resource_group_name, server_name, yes=None):


def flexible_server_restart(cmd, client, resource_group_name, server_name, fail_over=None):
instance = client.get(resource_group_name, server_name)
if fail_over is not None and instance.high_availability.mode != "ZoneRedundant":
raise ArgumentUsageError("Failing over can only be triggered for zone redundant servers.")

if fail_over is not None:
if fail_over != 'Forced':
raise InvalidArgumentValueError("Allowed failover parameters are 'Forced'.")
Expand Down