Conversation
lilypan26
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @lilypan26, |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jiasli,
wangzelin007 and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
lilypan26
changed the title
az aks nodepool add: Add GPU driver install options --gpu-driver install and --gpu-driver none
lilypan26
force-pushed
the
lily/add-gpu-profile-driver-install
branch
from
91db29c to
df074d0
Compare
added 2 commits
March 21, 2025 14:33
lilypan26
force-pushed
the
lily/add-gpu-profile-driver-install
branch
from
563c279 to
840e88e
Compare
lilypan26
force-pushed
the
lily/add-gpu-profile-driver-install
branch
from
1339913 to
242ac94
Compare
FumingZhang
reviewed
Mar 23, 2025
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
LGTM
Queued live test to validate the change.
Please fix style issue.
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/agentpool_decorator.py:1553:1: W293 blank line contains whitespace
/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/agentpool_decorator.py:1946:1: W293 blank line contains whitespace
added 3 commits
March 24, 2025 09:37
…y/add-gpu-profile-driver-install
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Apr 11, 2025
yanzhudd
changed the title
az aks nodepool add: Add GPU driver install options --gpu-driver install and --gpu-driver noneaz aks nodepool add: Add GPU driver install options install and none for --gpu-driver parameter
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Add GPU driver install configuration to GA CLI to allow customers to opt out of driver installation.
Testing Guide
History Notes
[AKS]
az aks nodepool add: Add GPU driver install options--gpu-driver installand--gpu-driver noneThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.