{ARM} Update azure-mgmt-resource SDK to latest#31162
Closed
{ARM} Update azure-mgmt-resource SDK to latest#31162
Conversation
jeskew
requested review from
bebound,
calvinhzy,
evelyn-ys,
jiasli,
jsntcy,
kairu-ms,
necusjz,
yanzhudd and
zhoxing-ms
as code owners
❌AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
ARM
jeskew
changed the title
zhoxing-ms
reviewed
Apr 1, 2025
| VSTS_7b238909-6802-4b65-b90d-184bca47f458_build_220_0 | ||
| method: GET | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/test_resource_id_arg_fmt000001?api-version=2022-09-01 | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/test_resource_id_arg_fmt000001?api-version=2024-11-01 |
Contributor
There was a problem hiding this comment.
Please try to re-record these YAML files using live testing instead of just replacing the api-version in the YAML files
Contributor
Author
There was a problem hiding this comment.
I'm having trouble finding any account where I can run azdev test resource --live without running into permissions issues.
Can I leave most of these files untouched (e.g., still using the 2022-09-01 API version), or would that cause the recorded tests to fail since the SDK will be using the 2024-11-01 API version? The API update is expected to have a minimal effect on only a handful of operations.
Contributor
There was a problem hiding this comment.
@jeskew We recommend that you try our bump api-version pipeline, which can automatically re-record YAML files using the CI pipeline. doc link: how_to_bump_SDK_version_in_cli.md
Contributor
Author
There was a problem hiding this comment.
Thanks for the guidance! All changes in this PR were now authored by that pipeline.
Contributor
Author
There was a problem hiding this comment.
I did need to manually patch a large number of recordings after running the pipeline, but this PR should be ready for review now.
jeskew
force-pushed
the
update-azure-mgmt-resource-SDK
branch
from
8525a0b to
dd1f1bf
Compare
jeskew
force-pushed
the
update-azure-mgmt-resource-SDK
branch
from
91bfdc0 to
612b6c6
Compare
jeskew
force-pushed
the
update-azure-mgmt-resource-SDK
branch
from
612b6c6 to
89ce6dd
Compare
jeskew
requested review from
AllyW,
FumingZhang,
Greedygre,
Juliehzl and
howang-ms
as code owners
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
please fix the CI issues and resolve the code conflicts. |
Contributor
|
please note that Azure CLI will have a code freeze on 04/21/2025 07:00 UTC for the upcoming release. Please address the comments ASAP, otherwise it has to be postponed to next sprint (05-19). |
yanzhudd
modified the milestones:
May 2025 (2025-05-06),
Build 2025 (2025-05-19)❗ Breaking change release ❗
Member
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31162 in repo Azure/azure-cli |
Collaborator
|
Please fix conflicts |
zhoxing-ms
modified the milestones:
Build 2025 (2025-05-19)❗ Breaking change release ❗,
June 2025 (2025-06-03)
Contributor
|
It should be replaced by PR https://github.com/Azure/azure-cli/pull/31449/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az deployment ...Description
This PR updates the SDK version for the
azure-mgmt-resource. Something about the Python SDK update seems to have caused a large number of tests to fail due to an incorrectContent-Lengthheader in the recordings, so this PR updates those. My team has multiple features blocked on this update, so it is happening in an isolated PR with no feature changes.Testing Guide
This PR relies on the existing tests.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.