Skip to content

[Compute] BREAKING CHANGE: az sig image-version create: Move to new properties #31186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 3 commits into from
Apr 8, 2025
+892 −853
Merged

[Compute] BREAKING CHANGE: az sig image-version create: Move to new properties #31186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad7d545
move properties
yanzhudd Apr 3, 2025
7e137ed
rerun tests
yanzhudd Apr 3, 2025
a5a8096
rerun tests
yanzhudd Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/vm/aaz/latest/sig/image_version/_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ def _build_args_gallery_disk_image_source_create(cls, _schema):
options=["id"],
help="The id of the gallery artifact version source. Can specify a disk uri, snapshot uri, user image or storage account resource.",
)
gallery_disk_image_source_create.storage_account_id = AAZStrArg(
gallery_disk_image_source_create.storage_account_id = AAZResourceIdArg(
options=["storage-account-id"],
help="The Storage Account Id that contains the vhd blob being used as a source for this artifact version.",
)
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/vm/aaz/latest/sig/image_version/_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ def _build_args_gallery_disk_image_source_update(cls, _schema):
help="The id of the gallery artifact version source. Can specify a disk uri, snapshot uri, user image or storage account resource.",
nullable=True,
)
gallery_disk_image_source_update.storage_account_id = AAZStrArg(
gallery_disk_image_source_update.storage_account_id = AAZResourceIdArg(
options=["storage-account-id"],
help="The Storage Account Id that contains the vhd blob being used as a source for this artifact version.",
nullable=True,
Expand Down
12 changes: 10 additions & 2 deletions src/azure-cli/azure/cli/command_modules/vm/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4883,7 +4883,12 @@ def create_image_version(cmd, resource_group_name, gallery_name, gallery_image_n
os_vhd_storage_account = resource_id(
subscription=get_subscription_id(cmd.cli_ctx), resource_group=resource_group_name,
namespace='Microsoft.Storage', type='storageAccounts', name=os_vhd_storage_account)
os_disk_image = {"source": {"id": os_vhd_storage_account, "uri": os_vhd_uri}}
os_disk_image = {
"source": {
"storage_account_id": os_vhd_storage_account,
"uri": os_vhd_uri
}
}

# Data disks
if data_vhds_uris and data_vhds_storage_accounts is None or \
Expand Down Expand Up @@ -4912,7 +4917,10 @@ def create_image_version(cmd, resource_group_name, gallery_name, gallery_image_n
if data_disk_images is None:
data_disk_images = []
for uri, lun, account in zip(data_vhds_uris, data_vhds_luns, data_vhds_storage_accounts):
data_disk_images.append({"source": {"id": account, "uri": uri}, "lun": lun})
data_disk_images.append({
"source": {"storage_account_id": account, "uri": uri},
"lun": lun
})

storage_profile = {"source": source, "os_disk_image": os_disk_image, "data_disk_images": data_disk_images}
args = {
Expand Down
Loading