From 6a1c7af3c9bc969f0a367e0840baaa201c1b6c07 Mon Sep 17 00:00:00 2001 From: Fuming Zhang Date: Fri, 4 Apr 2025 10:47:41 +1100 Subject: [PATCH 1/3] update --- .../azure/cli/command_modules/acs/version_history.md | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/azure-cli/azure/cli/command_modules/acs/version_history.md b/src/azure-cli/azure/cli/command_modules/acs/version_history.md index 83a032ed490..e2a322632b9 100644 --- a/src/azure-cli/azure/cli/command_modules/acs/version_history.md +++ b/src/azure-cli/azure/cli/command_modules/acs/version_history.md @@ -2,7 +2,16 @@ | azure-cli | API version | azure-mgmt-containerservice | |-|-|-| -| 2.55.0 (estimated) | 2023-10-01 | 28.0.0 | +| 2.71.0 | 2025-01-01 | 34.2.0 | +| 2.70.0 | 2024-10-01 | 34.1.0 | +| 2.67.0 | 2024-09-01 | 33.0.0 | +| 2.66.0 | 2024-08-01 | 32.1.0 | +| 2.65.0 | 2024-07-01 | 32.0.0 | +| 2.63.0 | 2024-05-01 | 31.0.0 | +| 2.59.0 | 2024-02-01 | 30.0.0 | +| 2.58.0 | 2024-01-01 | 29.1.0 | +| 2.57.0 | 2023-11-01 | 29.0.0 | +| 2.55.0 | 2023-10-01 | 28.0.0 | | 2.54.0 | 2023-08-01 | 27.0.0 | | 2.52.0, 2.53.0, 2.53.1 | 2023-07-01 | 26.0.0 | | 2.51.0 | 2023-06-01 | 25.0.0 | From a7bd81bdaf7fabe3886de321dc3a8b9a0b300361 Mon Sep 17 00:00:00 2001 From: Fuming Zhang Date: Fri, 4 Apr 2025 16:36:25 +1100 Subject: [PATCH 2/3] update --- .../command_modules/acs/_breaking_change.py | 21 ++++++++++++++++++- .../acs/managed_cluster_decorator.py | 13 ++++++++++++ 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/src/azure-cli/azure/cli/command_modules/acs/_breaking_change.py b/src/azure-cli/azure/cli/command_modules/acs/_breaking_change.py index 5917b30da9d..e1ad80e4766 100644 --- a/src/azure-cli/azure/cli/command_modules/acs/_breaking_change.py +++ b/src/azure-cli/azure/cli/command_modules/acs/_breaking_change.py @@ -3,7 +3,10 @@ # Licensed under the MIT License. See License.txt in the project root for license information. # -------- -from azure.cli.core.breaking_change import register_default_value_breaking_change +from azure.cli.core.breaking_change import ( + register_default_value_breaking_change, + register_conditional_breaking_change, +) register_default_value_breaking_change( 'aks create', @@ -11,3 +14,19 @@ 'Standard_DS2_V2 (Linux), Standard_DS2_V3 (Windows)', 'Dynamically Selected By Azure' ) + +register_conditional_breaking_change( + tag="aks_create_cluster_autoscaler_profile", + breaking_change="The option `--cluster-autoscaler-profile` in command `az aks create` will be changed to " + "allow multiple values for the same key, separated by commas. Different key-value pairs will be separated by " + "spaces.", + command_name="aks create", +) + +register_conditional_breaking_change( + tag="aks_update_cluster_autoscaler_profile", + breaking_change="The option `--cluster-autoscaler-profile` in command `az aks update` will be changed to " + "allow multiple values for the same key, separated by commas. Different key-value pairs will be separated by " + "spaces.", + command_name="aks update", +) diff --git a/src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py b/src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py index 3082392732a..9d399afd6f8 100644 --- a/src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py +++ b/src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py @@ -6282,6 +6282,13 @@ def set_up_auto_scaler_profile(self, mc: ManagedCluster) -> ManagedCluster: self._ensure_mc(mc) cluster_autoscaler_profile = self.context.get_cluster_autoscaler_profile() + if cluster_autoscaler_profile is not None: + from azure.cli.core.breaking_change import print_conditional_breaking_change + print_conditional_breaking_change( + self.cmd.cli_ctx, + tag="aks_create_cluster_autoscaler_profile", + custom_logger=logger + ) mc.auto_scaler_profile = cluster_autoscaler_profile return mc @@ -7076,6 +7083,12 @@ def update_auto_scaler_profile(self, mc): cluster_autoscaler_profile = self.context.get_cluster_autoscaler_profile() if cluster_autoscaler_profile is not None: # update profile (may clear profile with empty dictionary) + from azure.cli.core.breaking_change import print_conditional_breaking_change + print_conditional_breaking_change( + self.cmd.cli_ctx, + tag="aks_update_cluster_autoscaler_profile", + custom_logger=logger + ) mc.auto_scaler_profile = cluster_autoscaler_profile return mc From 3f4d075580ef7e94896add2bbdc13bc486488e4b Mon Sep 17 00:00:00 2001 From: Fuming Zhang Date: Fri, 4 Apr 2025 16:41:39 +1100 Subject: [PATCH 3/3] update --- .../command_modules/acs/_breaking_change.py | 21 ++++++++++++------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/src/azure-cli/azure/cli/command_modules/acs/_breaking_change.py b/src/azure-cli/azure/cli/command_modules/acs/_breaking_change.py index e1ad80e4766..63e894412c0 100644 --- a/src/azure-cli/azure/cli/command_modules/acs/_breaking_change.py +++ b/src/azure-cli/azure/cli/command_modules/acs/_breaking_change.py @@ -4,6 +4,7 @@ # -------- from azure.cli.core.breaking_change import ( + AzCLIOtherChange, register_default_value_breaking_change, register_conditional_breaking_change, ) @@ -17,16 +18,20 @@ register_conditional_breaking_change( tag="aks_create_cluster_autoscaler_profile", - breaking_change="The option `--cluster-autoscaler-profile` in command `az aks create` will be changed to " - "allow multiple values for the same key, separated by commas. Different key-value pairs will be separated by " - "spaces.", - command_name="aks create", + breaking_change=AzCLIOtherChange( + cmd="aks create", + message="The option `--cluster-autoscaler-profile` in command `az aks create` will be changed to " + "allow multiple values for the same key, separated by commas. Different key-value pairs will be separated by " + "spaces.", + ), ) register_conditional_breaking_change( tag="aks_update_cluster_autoscaler_profile", - breaking_change="The option `--cluster-autoscaler-profile` in command `az aks update` will be changed to " - "allow multiple values for the same key, separated by commas. Different key-value pairs will be separated by " - "spaces.", - command_name="aks update", + breaking_change=AzCLIOtherChange( + cmd="aks update", + message="The option `--cluster-autoscaler-profile` in command `az aks update` will be changed to " + "allow multiple values for the same key, separated by commas. Different key-value pairs will be separated by " + "spaces.", + ), )