Skip to content

{Core} Fix #31222: aaz: Subresource can be empty #31223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
necusjz wants to merge 2 commits into from
Closed

{Core} Fix #31222: aaz: Subresource can be empty #31223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b649ae6
fix: subresource can be empty
necusjz Apr 9, 2025
18f055c
style: remove unused import
necusjz Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/azure-cli-core/azure/cli/core/aaz/_selector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
# from azure.core.exceptions import ResourceExistsError, ResourceNotFoundError
from azure.cli.core.azclierror import UserFault

from ._base import has_value
from .exceptions import AAZUnknownFieldError


Expand Down Expand Up @@ -55,6 +54,4 @@ def set(self, value):

def required(self):
value = self.get()
if not has_value(value):
raise UserFault("ResourceNotFoundError")
return value
Copy link
Copy Markdown
Contributor

@kairu-ms kairu-ms Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after change what's the difference between required and get? I think the correct way is fix the generated code which use required() to get()