{App Service} Hotfix: Remove fileshare validation

.azure-pipelines/templates/variables.yml

@@ -2,5 +2,5 @@ variables:
   ubuntu_pool: 'pool-ubuntu-2204'
   ubuntu_multi_core_pool: 'pool-ubuntu-latest-multi-core'
   windows_pool: 'pool-windows-2019'
-  ubuntu_arm64_pool: 'ubuntu-arm64-2004-pool'
+  ubuntu_arm64_pool: 'pool-ubuntu-latest-arm64'
   macos_pool: 'macOS-14'

.github/CODEOWNERS

@@ -21,48 +21,48 @@
 
 /src/azure-cli/azure/cli/command_modules/acr/ @zhoxing-ms @northtyphoon @rosanch @jsntcy @yanzhudd
 /src/azure-cli/azure/cli/command_modules/acs/ @zhoxing-ms @zqingqing1 @gtracer @xizhamsft @andyliuliming @fumingzhang @jsntcy @yanzhudd
-/src/azure-cli/azure/cli/command_modules/advisor/ @Prasanna-Padmanabhan
-/src/azure-cli/azure/cli/command_modules/apim/ @kevinhillinger @jonlester
-/src/azure-cli/azure/cli/command_modules/appconfig/ @ChristineWanjau @albertofori @avanigupta @zhoxing-ms @jsntcy @yanzhudd
-/src/azure-cli/azure/cli/command_modules/appservice/ @panchagnula @jsntcy @zhoxing-ms @yanzhudd
-/src/azure-cli/azure/cli/command_modules/aro/ @bennerv @hawkowl @jewzaam @rogbas
-/src/azure-cli/azure/cli/command_modules/backup/ @dragonfly91 @zhoxing-ms @akshayneema @jsntcy @yanzhudd
-/src/azure-cli/azure/cli/command_modules/batch/ @cRui861 @wanghoppe @dpwatrous @wiboris @zhoxing-ms @jsntcy @yanzhudd
-/src/azure-cli/azure/cli/command_modules/batchai/ @AlexanderYukhanov
-/src/azure-cli/azure/cli/command_modules/botservice/ @jiaxuwu2021 @luhan2017
+/src/azure-cli/azure/cli/command_modules/advisor/ @jsntcy @Prasanna-Padmanabhan
+/src/azure-cli/azure/cli/command_modules/apim/ @jsntcy @kevinhillinger @jonlester
+/src/azure-cli/azure/cli/command_modules/appconfig/ @zhoxing-ms @jsntcy @yanzhudd @ChristineWanjau @albertofori @avanigupta
+/src/azure-cli/azure/cli/command_modules/appservice/ @jsntcy @zhoxing-ms @yanzhudd @panchagnula
+/src/azure-cli/azure/cli/command_modules/aro/ @jsntcy @bennerv @hawkowl @jewzaam @rogbas
+/src/azure-cli/azure/cli/command_modules/backup/ @zhoxing-ms @jsntcy @yanzhudd @dragonfly91 @akshayneema
+/src/azure-cli/azure/cli/command_modules/batch/ @zhoxing-ms @jsntcy @yanzhudd @cRui861 @wanghoppe @dpwatrous @wiboris
+/src/azure-cli/azure/cli/command_modules/batchai/ @jsntcy @AlexanderYukhanov
+/src/azure-cli/azure/cli/command_modules/botservice/ @jsntcy @jiaxuwu2021 @luhan2017
 /src/azure-cli/azure/cli/command_modules/cdn/ @jsntcy @kairu-ms @wangzelin007 @necusjz @t-bzhan
 /src/azure-cli/azure/cli/command_modules/cloud/ @jiasli @evelyn-ys
-/src/azure-cli/azure/cli/command_modules/consumption/ @sandeepnl
-/src/azure-cli/azure/cli/command_modules/container/ @joseph-porter
-/src/azure-cli/azure/cli/command_modules/cosmosdb/ @dmakwana @kristynhamasaki @evelyn-ys @calvinhzy
+/src/azure-cli/azure/cli/command_modules/consumption/ @jsntcy @sandeepnl
+/src/azure-cli/azure/cli/command_modules/container/ @jsntcy @joseph-porter
+/src/azure-cli/azure/cli/command_modules/cosmosdb/ @evelyn-ys @calvinhzy @dmakwana @kristynhamasaki
 /src/azure-cli/azure/cli/command_modules/databoxedge/ @evelyn-ys
-/src/azure-cli/azure/cli/command_modules/dls/ @akharit @rahuldutta90 @jsntcy @yonzhan @evelyn-ys
-/src/azure-cli/azure/cli/command_modules/dms/ @temandr @binuj
+/src/azure-cli/azure/cli/command_modules/dls/ @jsntcy @evelyn-ys @akharit @rahuldutta90
+/src/azure-cli/azure/cli/command_modules/dms/ @jsntcy @temandr @binuj
 /src/azure-cli/azure/cli/command_modules/eventgrid/ @evelyn-ys @VidyaKukke
-/src/azure-cli/azure/cli/command_modules/eventhubs/ @v-ajnava
+/src/azure-cli/azure/cli/command_modules/eventhubs/ @jsntcy @v-ajnava
 /src/azure-cli/azure/cli/command_modules/extension/ @jsntcy @kairu-ms
 /src/azure-cli/azure/cli/command_modules/feedback/ @jiasli @kairu-ms
-/src/azure-cli/azure/cli/command_modules/hdinsight/ @aim-for-better @kairu-ms
+/src/azure-cli/azure/cli/command_modules/hdinsight/ @kairu-ms @aim-for-better
 /src/azure-cli/azure/cli/command_modules/identity/ @zhoxing-ms @jiasli @yanzhudd
-/src/azure-cli/azure/cli/command_modules/iot/ @digimaun @zhoxing-ms @yanzhudd
+/src/azure-cli/azure/cli/command_modules/iot/ @zhoxing-ms @yanzhudd @digimaun
 /src/azure-cli/azure/cli/command_modules/keyvault/ @evelyn-ys @jiasli @calvinhzy
 /src/azure-cli/azure/cli/command_modules/monitor/ @jsntcy @kairu-ms @necusjz @AllyW
-/src/azure-cli/azure/cli/command_modules/mysql/ @honghr @evelyn-ys
-/src/azure-cli/azure/cli/command_modules/natgateway/ @khannarheams @jsntcy @kairu-ms @necusjz
+/src/azure-cli/azure/cli/command_modules/mysql/ @evelyn-ys @honghr
+/src/azure-cli/azure/cli/command_modules/natgateway/ @jsntcy @kairu-ms @necusjz @khannarheams
 /src/azure-cli/azure/cli/command_modules/network/ @jsntcy @kairu-ms @wangzelin007 @necusjz
-/src/azure-cli/azure/cli/command_modules/policyinsights/ @cheggert
+/src/azure-cli/azure/cli/command_modules/policyinsights/ @jsntcy @cheggert
 /src/azure-cli/azure/cli/command_modules/privatedns/ @jsntcy @kairu-ms @necusjz
 /src/azure-cli/azure/cli/command_modules/profile/ @jiasli @evelyn-ys @bebound
-/src/azure-cli/azure/cli/command_modules/rdbms/ @arde0708 @evelyn-ys @calvinhzy @alanenriqueo
+/src/azure-cli/azure/cli/command_modules/rdbms/ @evelyn-ys @calvinhzy @arde0708 @alanenriqueo
 /src/azure-cli/azure/cli/command_modules/resource/ @zhoxing-ms @jsntcy @yanzhudd
 /src/azure-cli/azure/cli/command_modules/role/ @jiasli @evelyn-ys @bebound
-/src/azure-cli/azure/cli/command_modules/search/ @huangbolun @kairu-ms
-/src/azure-cli/azure/cli/command_modules/servicebus/ @v-ajnava @zhoxing-ms @jsntcy @evelyn-ys
-/src/azure-cli/azure/cli/command_modules/serviceconnector/ @yungezz @houk-ms @xfz11 @yanzhudd @kairu-ms
-/src/azure-cli/azure/cli/command_modules/servicefabric/ @QingChenmsft @zhoxing-ms @jsntcy @yanzhudd
-/src/azure-cli/azure/cli/command_modules/sql/ @jaredmoo @evelyn-ys @calvinhzy
+/src/azure-cli/azure/cli/command_modules/search/ @kairu-ms @huangbolun
+/src/azure-cli/azure/cli/command_modules/servicebus/ @zhoxing-ms @jsntcy @evelyn-ys @v-ajnava
+/src/azure-cli/azure/cli/command_modules/serviceconnector/ @kairu-ms @yanzhudd @yungezz @houk-ms @xfz11
+/src/azure-cli/azure/cli/command_modules/servicefabric/ @zhoxing-ms @jsntcy @yanzhudd @QingChenmsft
+/src/azure-cli/azure/cli/command_modules/sql/ @evelyn-ys @calvinhzy @jaredmoo
 /src/azure-cli/azure/cli/command_modules/storage/ @jsntcy @zhoxing-ms @evelyn-ys @calvinhzy
 /src/azure-cli/azure/cli/command_modules/synapse/ @jsntcy @idear1203 @zesluo @evelyn-ys
 /src/azure-cli/azure/cli/command_modules/util/ @jiasli @zhoxing-ms @evelyn-ys
 /src/azure-cli/azure/cli/command_modules/vm/ @zhoxing-ms @jsntcy @wangzelin007 @yanzhudd @Drewm3 @TravisCragg-MSFT @nikhilpatel909 @sandeepraichura @hilaryw29 @GabstaMSFT @ramankumarlive @ushnaarshadkhan
-/src/azure-cli/azure/cli/command_modules/containerapp/ @ruslany @sanchitmehta @ebencarek @JennyLawrance @howang-ms @vinisoto @chinadragon0515 @vturecek @torosent @pagariyaalok @Juliehzl @jijohn14 @Greedygre @zhoxing-ms @yanzhudd @ShichaoQiu
+/src/azure-cli/azure/cli/command_modules/containerapp/ @zhoxing-ms @yanzhudd @ruslany @sanchitmehta @ebencarek @JennyLawrance @howang-ms @vinisoto @chinadragon0515 @vturecek @torosent @pagariyaalok @Juliehzl @jijohn14 @Greedygre @ShichaoQiu

azure-pipelines.yml

@@ -30,7 +30,7 @@ parameters:
     pool: pool-ubuntu-latest-multi-core
   - name: ARM64
     value: arm64
-    pool: ubuntu-arm64-2004-pool
+    pool: pool-ubuntu-latest-arm64
 
 jobs:
 - job: CheckPullRequest
@@ -567,7 +567,7 @@ jobs:
 - job: TestExtensionsLoading
   displayName: Test Extensions Loading
   condition: succeeded()
-  timeoutInMinutes: 40
+  timeoutInMinutes: 80
 
   pool:
     name: ${{ variables.ubuntu_pool }}

doc/how_to_introduce_breaking_changes.md

@@ -274,26 +274,42 @@ register_other_breaking_change('bar foo', 'During May 2024, another Breaking Cha
 
 **Conditional Breaking Change**
 
-To enhance flexibility, the CLI supports using a designated tag to specify a Breaking Change Pre-announcement. This method avoids reliance on the default automatic warning display and allows the warning to be shown whenever `print_manual_breaking_change` is called.
+To enhance flexibility, the CLI supports using a designated tag to specify a Breaking Change Pre-announcement. This method avoids reliance on the default automatic warning display and allows the warning to be shown whenever `print_conditional_breaking_change` is called.
 
 **Note:** We strongly recommend using this method to display breaking change warnings under specific conditions instead of using `logger.warning` directly. This approach enables centralized documentation of breaking changes and assists in automating customer notifications.
 
+* Register
+  * `tag`: The tag of the conditional breaking change. Use the same tag to print.
+  * `breaking_change`: Breaking change item to be announced. This should be an instance of `BreakingChange` subclass or a string. You should provide `command_name` when it is a string.
+  * `command_name`: Used only when input str as a breaking change. This would restrict the scope of breaking change tag.
+* Print
+  * `cli_ctx`: Context object. Pass this as `None` only when specifying `command_name` manually.
+  * `tag` : The tag of the conditional breaking change. Use the same tag to print.
+  * `custom_logger`: The logger used to print the warning.
+  * `command_name`: Used only when `cli_ctx` is `None`.
+
 ```python
 # src/azure-cli/azure/cli/command_modules/vm/_breaking_change.py
-from azure.cli.core.breaking_change import AzCLIOtherChange, register_conditional_breaking_change
+from azure.cli.core.breaking_change import register_conditional_breaking_change, AzCLIOtherChange
 
 register_conditional_breaking_change(tag='SpecialBreakingChangeA', breaking_change=AzCLIOtherChange(
-  'vm create', 'This is special Breaking Change Warning A. This breaking change is happend in "vm create" command.'))
-register_conditional_breaking_change(tag='SpecialBreakingChangeB', breaking_change=AzCLIOtherChange(
-  'vm', 'This is special Breaking Change Warning B. This breaking change is happend in "vm" command group.'))
+    'vm create', 'This is special Breaking Change Warning A. This breaking change is happend in "vm create" command.'))
+register_conditional_breaking_change(
+    tag='SpecialBreakingChangeB',
+    breaking_change='This is special Breaking Change Warning B. This breaking change is happend in "vm" command group.',
+    command_name='vm'
+)
 
 
 # src/azure-cli/azure/cli/command_modules/vm/custom.py
 def create_vm(cmd, vm_name, **):
-  from azure.cli.core.breaking_change import print_conditional_breaking_change
-  if some_condition:
-    print_conditional_breaking_change(cmd.cli_ctx, tag='SpecialBreakingChangeA', custom_logger=logger)
-    print_conditional_breaking_change(cmd.cli_ctx, tag='SpecialBreakingChangeB', custom_logger=logger)
+    from azure.cli.core.breaking_change import print_conditional_breaking_change
+    if some_condition:
+        print_conditional_breaking_change(cmd.cli_ctx, tag='SpecialBreakingChangeA', custom_logger=logger)
+        print_conditional_breaking_change(cmd.cli_ctx, tag='SpecialBreakingChangeB', custom_logger=logger)
+
+# This is special Breaking Change Warning A. This breaking change is happend in "vm create" command.
+# This is special Breaking Change Warning B. This breaking change is happend in "vm" command group.
 ```
 
 This way, the pre-announcement wouldn't be displayed unless running into the branch, but still could be published in the [Azure CLI Breaking Changes]() article.

scripts/ci/install_docker.sh

@@ -5,11 +5,8 @@ if [[ $(dpkg --print-architecture) == "amd64" ]]; then
     echo "Docker is already installed on AMD64"
     exit 0
 fi
-# https://docs.docker.com/engine/security/rootless/
-/bin/bash -c "$(curl -fsSL https://get.docker.com)"
-sudo apt-get install -y uidmap
-dockerd-rootless-setuptool.sh install
-export XDG_RUNTIME_DIR=/home/cloudtest/.docker/run
-PATH=/usr/bin:/sbin:/usr/sbin:$PATH dockerd-rootless.sh &
-sleep 5
-docker context use rootless
+
+# https://docs.docker.com/engine/install/ubuntu/#install-using-the-convenience-script
+curl -fsSL https://get.docker.com -o get-docker.sh
+sudo sh ./get-docker.sh
+sudo chmod 666 /var/run/docker.sock

src/azure-cli-core/azure/cli/core/__init__.py

@@ -220,7 +220,8 @@ def load_command_table(self, args):
             _load_module_command_loader, _load_extension_command_loader, BLOCKED_MODS, ExtensionCommandSource)
         from azure.cli.core.extension import (
             get_extensions, get_extension_path, get_extension_modname)
-        from azure.cli.core.breaking_change import (import_module_breaking_changes, import_extension_breaking_changes)
+        from azure.cli.core.breaking_change import (
+            import_core_breaking_changes, import_module_breaking_changes, import_extension_breaking_changes)
 
         def _update_command_table_from_modules(args, command_modules=None):
             """Loads command tables from modules and merge into the main command table.
@@ -416,6 +417,9 @@ def _get_extension_suppressions(mod_loaders):
         self.command_group_table.clear()
         self.command_table.clear()
 
+        # Import announced breaking changes in azure.cli.core._breaking_change.py
+        import_core_breaking_changes()
+
         command_index = None
         # Set fallback=False to turn off command index in case of regression
         use_command_index = self.cli_ctx.config.getboolean('core', 'use_command_index', fallback=True)

src/azure-cli-core/azure/cli/core/_breaking_change.py

@@ -0,0 +1,15 @@
+# --------------------------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for license information.
+# --------------------------------------------------------------------------------------------
+# pylint: disable=line-too-long
+
+from azure.cli.core.breaking_change import AzCLIOtherChange, register_conditional_breaking_change
+
+register_conditional_breaking_change(
+    tag='CloudProfilesDeprecate',
+    breaking_change=AzCLIOtherChange(
+        cmd='',
+        message="Starting from 2.73.0, the azure stack profiles ('2017-03-09-profile', '2018-03-01-hybrid', '2019-03-01-hybrid', '2020-09-01-hybrid') will be deprecated. Please use the 'latest' profile or the CLI 2.66.* (LTS) version instead."
+    )
+)

src/azure-cli-core/azure/cli/core/_profile.py

@@ -1022,6 +1022,8 @@ def _create_identity_instance(cli_ctx, authority, tenant_id=None, client_id=None
 def _use_msal_managed_identity(cli_ctx):
     # This indicates an Azure Arc-enabled server
     from msal.managed_identity import get_managed_identity_source, AZURE_ARC
+    from azure.cli.core.telemetry import set_use_msal_managed_identity
     # PREVIEW: Use core.use_msal_managed_identity=true to enable managed identity authentication with MSAL
     use_msal_managed_identity = cli_ctx.config.getboolean('core', 'use_msal_managed_identity', fallback=False)
+    set_use_msal_managed_identity(use_msal_managed_identity)
     return use_msal_managed_identity or get_managed_identity_source() == AZURE_ARC

src/azure-cli-core/azure/cli/core/auth/identity.py

@@ -112,7 +112,9 @@ def _msal_app_kwargs(self):
     def _msal_public_app_kwargs(self):
         """kwargs for creating PublicClientApplication."""
         # enable_broker_on_windows can only be used on PublicClientApplication.
-        return {**self._msal_app_kwargs, "enable_broker_on_windows": self._enable_broker_on_windows}
+        return {**self._msal_app_kwargs,
+                "enable_broker_on_windows": self._enable_broker_on_windows,
+                "enable_pii_log": True}
 
     @property
     def _msal_app(self):