{NetAppFiles} Anf 50895 netapp 2025 01 01#31254
Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| netappfiles account create | cmd netappfiles account create added parameter federated_client_id |
||
| netappfiles account create | cmd netappfiles account create added parameter nfs_v4_id_domain |
||
| netappfiles account create | cmd netappfiles account create added parameter user_assigned_identities |
||
| netappfiles account update | cmd netappfiles account update added parameter federated_client_id |
||
| netappfiles account update | cmd netappfiles account update added parameter nfs_v4_id_domain |
||
| netappfiles account update | cmd netappfiles account update added parameter user_assigned_identities |
||
| netappfiles usage | sub group netappfiles usage added |
||
| netappfiles volume-group create | cmd netappfiles volume-group create update parameter proximity_placement_group: removed property required=True |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jiasli,
kairu-ms and
yonzhan
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31254 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31254 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31254 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31254 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
kairu-ms
changed the title
| args_schema.is_restoring = AAZBoolArg( | ||
| options=["--is-restoring"], | ||
| arg_group="Properties", | ||
| help="Restoring. Deprecated, do not use will be removed in future version.", |
There was a problem hiding this comment.
You can follow this guide line to add breaking change information for those arguments https://github.com/Azure/azure-cli/blob/dev/doc/how_to_introduce_breaking_changes.md
There was a problem hiding this comment.
added _breaking_change.py
| # -------------------------------------------------------------------------------------------- | ||
| from azure.cli.core.breaking_change import register_argument_deprecate | ||
|
|
||
| register_argument_deprecate('netappfiles volume create', '--is-restoring', target_version='2.73.0') |
There was a problem hiding this comment.
The next release is 2.73.0, actually you should create PR for breaking change now. But I will merge it first so that our breaking change notes will include those items
There was a problem hiding this comment.
We need this in: 2.72.0 05/06/2025 .
The thinking was to relase this now and follow up with a PR including the breaking changes in 2.73.0
There was a problem hiding this comment.
@kairu-ms thoughts on above can we release this in 2.72.0, 05/06/2025?
There was a problem hiding this comment.
Sorry, the code freeze day for 2.72.0 is 3 weeks ago. So the next release is 2.73.0
There was a problem hiding this comment.
Usually those breaking change warnings messages should be merged at least 2 versions before breaking changes. Such as 2.71.0
There was a problem hiding this comment.
We started this pr April 11, but there was little traction on it, what would be the best way to get things reviewd so we get things reviewed in time?
@kairu-ms good to know about the breaking changes, we will keep that in mind thanks.
One question at what point does this get updated ?
https://learn.microsoft.com/en-us/cli/azure/upcoming-breaking-changes
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
3 participants
Related command
NetAppFiles
Description
Update az netappfiles to api-version 2025-01-01
Testing Guide
History Notes
[NetAppFiles]
az volume-group create: Parameter--proximity-placement-groupis no longer required[NetAppFiles]
az netappfiles account create: Add new parameter--federated-client-idfor Cross Tennant CMK[NetAppFiles]
az netappfiles account create: Add new parameter--nfs-v4-id-domain. Domain for NFSv4 user ID mapping[NetAppFiles]
az netappfiles account update: Add new parameter--federated-client-idfor Cross Tennant CMK[NetAppFiles]
az netappfiles account update: Add new parameter--nfs-v4-id-domain. Domain for NFSv4 user ID mapping[NetAppFiles]
az netappfiles usage list: Add new command to list current subscription usages[NetAppFiles]
az netappfiles usage show: Add new command to list current subscription usagesThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.