-
Notifications
You must be signed in to change notification settings - Fork 3.4k
{NetAppFiles} Anf 50895 netapp 2025 01 01 #31254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c309fcd
2025-01-01
audunn ea7b3fe
style
audunn 8c09551
update
audunn e40aa0f
style
audunn 37341f2
add option u
audunn 24461a8
custom braking
audunn 66a2c3b
custom braking
audunn 95bbb16
volume group oracle example
audunn f113960
volume group oracle example
audunn 89f7eda
style
audunn 61da4cc
style 2
audunn e90faad
test recordings
audunn 0918dd5
add _braking_change.py
audunn 71ee3dd
add endpoint type to upcoming breaking changes
audunn bdb6a54
style
audunn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
16 changes: 16 additions & 0 deletions
16
src/azure-cli/azure/cli/command_modules/netappfiles/_breaking_change.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # -------------------------------------------------------------------------------------------- | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. See License.txt in the project root for license information. | ||
| # -------------------------------------------------------------------------------------------- | ||
| from azure.cli.core.breaking_change import register_argument_deprecate | ||
|
|
||
| register_argument_deprecate('netappfiles volume create', '--is-restoring', target_version='2.73.0') | ||
| register_argument_deprecate('netappfiles volume update', '--avs-data-store', target_version='2.73.0') | ||
| register_argument_deprecate('netappfiles volume update', '--creation-token', target_version='2.73.0') | ||
| register_argument_deprecate('netappfiles volume update', '--is-large-volume', target_version='2.73.0') | ||
| register_argument_deprecate('netappfiles volume update', '--is-restoring', target_version='2.73.0') | ||
| register_argument_deprecate('netappfiles volume update', '--ldap-enabled', target_version='2.73.0') | ||
| register_argument_deprecate('netappfiles volume update', '--network-features', target_version='2.73.0') | ||
| register_argument_deprecate('netappfiles volume update', '--security-style', target_version='2.73.0') | ||
| register_argument_deprecate('netappfiles volume update', '--volume-type', target_version='2.73.0') | ||
| register_argument_deprecate('netappfiles volume update', '--endpoint-type', target_version='2.73.0') | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next release is 2.73.0, actually you should create PR for breaking change now. But I will merge it first so that our breaking change notes will include those items
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this in: 2.72.0 05/06/2025 .
The thinking was to relase this now and follow up with a PR including the breaking changes in 2.73.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kairu-ms thoughts on above can we release this in 2.72.0, 05/06/2025?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the code freeze day for 2.72.0 is 3 weeks ago. So the next release is 2.73.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually those breaking change warnings messages should be merged at least 2 versions before breaking changes. Such as 2.71.0
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We started this pr April 11, but there was little traction on it, what would be the best way to get things reviewd so we get things reviewed in time?
@kairu-ms good to know about the breaking changes, we will keep that in mind thanks.
One question at what point does this get updated ?
https://learn.microsoft.com/en-us/cli/azure/upcoming-breaking-changes