Skip to content

{AFD} Fix bug for az afd rule action list #31260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
necusjz merged 2 commits into from
Apr 15, 2025
Merged

{AFD} Fix bug for az afd rule action list #31260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4107f4a
Bug fix
Apr 14, 2025
36653cb
remove test that is not used anymore
Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/azure-cli/azure/cli/command_modules/cdn/custom/custom_afdx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,9 +1111,6 @@ class AFDRuleActionShow(_RuleShow):
@classmethod
def _build_arguments_schema(cls, *args, **kwargs):
args_schema = super()._build_arguments_schema(*args, **kwargs)
args_schema.actions._registered = False
args_schema.conditions._registered = False
args_schema.ids._registered = False
return args_schema

def _output(self, *args, **kwargs):
Expand All @@ -1125,9 +1122,6 @@ class AFDRuleConditionShow(_RuleShow):
@classmethod
def _build_arguments_schema(cls, *args, **kwargs):
args_schema = super()._build_arguments_schema(*args, **kwargs)
args_schema.actions._registered = False
args_schema.conditions._registered = False
args_schema.ids._registered = False
return args_schema

def _output(self, *args, **kwargs):
Expand Down
6 changes: 6 additions & 0 deletions src/azure-cli/azure/cli/command_modules/cdn/tests/latest/afdx_scenario_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,12 @@ def afd_rule_show_cmd(self, resource_group_name, rule_set_name, rule_name, profi

return self.cmd(command, checks)

def afd_rule_action_show_cmd(self, resource_group_name, rule_set_name, rule_name, profile_name, checks=None):
command = f'az afd rule action list -g {resource_group_name} --rule-set-name {rule_set_name} ' \
f'--profile-name {profile_name} -n {rule_name}'

return self.cmd(command, checks)

def afd_rule_add_cmd(self, resource_group_name, rule_set_name, rule_name, profile_name, options=None, checks=None):
command = f'az afd rule create -g {resource_group_name} --rule-set-name {rule_set_name} ' \
f'--profile-name {profile_name} --rule-name {rule_name}'
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/cdn/tests/latest/test_afd_rule_scenarios.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,4 +648,4 @@ def test_afd_rule_actions(self, resource_group):
for rule_name in ["r1", "r2", "r3", "r4", "r5"]:
self.afd_rule_delete_cmd(resource_group, rule_set_name, rule_name, profile_name)

self.afd_rule_set_delete_cmd(resource_group, rule_set_name, profile_name)
self.afd_rule_set_delete_cmd(resource_group, rule_set_name, profile_name)