Skip to content

{serviceconnector} Fix issue #31145: az functionapp connection does not support slot #31272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kairu-ms merged 11 commits into from
Apr 18, 2025
Merged

{serviceconnector} Fix issue #31145: az functionapp connection does not support slot #31272

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3c60339
Merge pull request #1 from Azure/dev
qianwens Feb 11, 2020
9892177
Merge pull request #3 from Azure/dev
qianwens Feb 18, 2020
80f0d50
Merge pull request #5 from Azure/dev
qianwens Mar 19, 2020
4e68f81
Merge pull request #6 from Azure/dev
qianwens Apr 7, 2020
36e93df
Merge pull request #7 from Azure/dev
qianwens Apr 16, 2020
ce2ad33
Merge pull request #9 from Azure/dev
qianwens Apr 29, 2020
2213497
Merge pull request #10 from Azure/dev
qianwens May 13, 2020
003f067
Merge pull request #11 from Azure/dev
qianwens May 25, 2020
60cacdb
Merge pull request #12 from Azure/dev
qianwens Sep 1, 2020
2dd4e9c
Merge pull request #14 from Azure/dev
qianwens Apr 15, 2025
288a71e
fix func slot bug
qianwens Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/serviceconnector/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ def validate_source_resource_id(cmd, namespace):
source = get_source_resource_name(cmd)

# For Web App, match slot pattern first:
if source == RESOURCE.WebApp:
if source == RESOURCE.WebApp or source == RESOURCE.FunctionApp:
slotPattern = WEB_APP_SLOT_RESOURCE
matched = re.match(get_resource_regex(slotPattern), namespace.source_id, re.IGNORECASE)
if matched:
Expand Down Expand Up @@ -742,7 +742,7 @@ def apply_source_optional_args(cmd, namespace, arg_values):
'''Set source resource id by optional arg_values
'''
source = get_source_resource_name(cmd)
if source == RESOURCE.WebApp:
if source == RESOURCE.WebApp or source == RESOURCE.FunctionApp:
if arg_values.get('slot', None):
resource = WEB_APP_SLOT_RESOURCE
if check_required_args(resource, arg_values):
Expand Down