{ACR} az acr connected-registry: Change version for connected registry to 2025-04-01#31382
Conversation
trisavo-msft
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
Build 2025 (2025-05-19)❗ Breaking change release ❗ milestone
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
JXavierMSFT,
northtyphoon,
rosanch,
shizhMSFT,
terencet-dev,
toddysm and
yonzhan
trisavo-msft
changed the title
az acr connected-registry: Change version for connected registry to 2025-04-01
microsoft-github-policy-service
bot
added
Auto-Assign
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
trisavo-msft
requested review from
Greedygre,
Juliehzl and
howang-ms
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Python SDK team's intention is to make the package code structure more clear and we expect SDK users are not impacted. It seems that CLI has special ask in CI so you can contact CLI team member for help. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@trisavo-msft Could you please resolve these conflicts? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
modified the milestones:
Build 2025 (2025-05-19)❗ Breaking change release ❗,
June 2025 (2025-06-03)
zhoxing-ms
changed the title
az acr connected-registry: Change version for connected registry to 2025-04-01az acr connected-registry: Change version for connected registry to 2025-04-01
| importlib.import_module('.'+label+'.models', main_module.__name__) | ||
| for (_, label, ispkg) in pkgutil.iter_modules(main_module.__path__) | ||
| if ispkg and label != 'aio' | ||
| if ispkg and label != 'aio' and label != '_utils' |
There was a problem hiding this comment.
@jiasli Could you help review the build_scripts related code?
There was a problem hiding this comment.
L246~L247 indicates this function processes all models module under API-specific folders, such as <main_module>.v2015_04_01.models.
azure-cli/build_scripts/windows/scripts/patch_models_v2.py
Lines 246 to 247 in 6cbb614
_utils doesn't have models at all:
So, it is reasonable to exclude _utils here. However, this solution is very fragile as it depends on _utils's structure.
Currently, _utils exists in both the root folder of the mgmt SDK and also API-specific folders:
breaking of fact that each API-specific folder is separated and self-containing. serialization.py files in different _utils also contain duplicated code. SDK team should confirm if this is a bug in autorest and remove the duplication.
There was a problem hiding this comment.
@msyyc Could you please help take a look at this SDK issue?
There was a problem hiding this comment.
I think we can validate xxx.xxx.models pkg exists before we import it in our build script.
Made a pr for dealing with it: #31470
There was a problem hiding this comment.
@zhoxing-ms / @jiasli, Yeah, _utils are duplicated in multiapi package just like _vendor.py in old structure. Since we plan to gradually drop multiapi package started from May as planned before with @kairu-ms, azure cli could drop the build script which is for multiapi in short future.
|
@zhoxing-ms , why this is moved to June milestone? |
src/azure-cli/azure/cli/command_modules/appservice/tests/latest/test_functionapp_commands.py
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
modified the milestones:
June 2025 (2025-06-03),
Build 2025 (2025-05-19)❗ Breaking change release ❗
9 participants
Related command
Description
Updated version for connected registry to 2025-04-01.
Testing Guide
History Notes
[ACR]
az acr connected-registry: Update api version of connected registry to 2025-04-01This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.