-
Notifications
You must be signed in to change notification settings - Fork 3.4k
{ACR} az acr connected-registry: Change version for connected registry to 2025-04-01
#31382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zhoxing-ms
merged 14 commits into
Azure:dev
from
trisavo-msft:trisavo/update-ga-api-connected-registry
May 13, 2025
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
661bdb0
Change version for connected registrsy to 2025-04-01
trisavo-msft af5ff1c
Update recording
trisavo-msft c9ec5f3
Changes
trisavo-msft a169a9e
Update shared
trisavo-msft 9a0eb9d
make appservice test live_only because end-of-life
trisavo-msft 3e10437
update _shared
trisavo-msft 79bfbab
style
trisavo-msft 7fe75ae
Revert
trisavo-msft 078bf3b
Modify patch_models script to check if exists
trisavo-msft 0ee8d06
exclude utils
trisavo-msft 496244a
Merge conflict
trisavo-msft bba5913
Modify method for script
trisavo-msft 6dd0657
Remove live_only
trisavo-msft 3732f59
Merge branch 'dev' into trisavo/update-ga-api-connected-registry
trisavo-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3,130 changes: 1,547 additions & 1,583 deletions
3,130
...cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_connectedregistry.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
578 changes: 279 additions & 299 deletions
578
...tests/latest/recordings/test_containerapp_manualjob_registry_acr_look_up_credentical.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
699 changes: 393 additions & 306 deletions
699
...tainerapp/tests/latest/recordings/test_containerapp_registry_acr_look_up_credentical.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
1,159 changes: 550 additions & 609 deletions
1,159
...mand_modules/containerapp/tests/latest/recordings/test_containerappjob_registry_crud.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiasli Could you help review the build_scripts related code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L246~L247 indicates this function processes all
modelsmodule under API-specific folders, such as<main_module>.v2015_04_01.models.azure-cli/build_scripts/windows/scripts/patch_models_v2.py
Lines 246 to 247 in 6cbb614
_utilsdoesn't havemodelsat all:https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/containerregistry/azure-mgmt-containerregistry/azure/mgmt/containerregistry/_utils
So, it is reasonable to exclude
_utilshere. However, this solution is very fragile as it depends on_utils's structure.Currently,
_utilsexists in both the root folder of the mgmt SDK and also API-specific folders:breaking of fact that each API-specific folder is separated and self-containing.
serialization.pyfiles in different_utilsalso contain duplicated code. SDK team should confirm if this is a bug in autorest and remove the duplication.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msyyc Could you please help take a look at this SDK issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can validate
xxx.xxx.modelspkg exists before we import it in our build script.Made a pr for dealing with it: #31470
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhoxing-ms / @jiasli, Yeah,
_utilsare duplicated in multiapi package just like_vendor.pyin old structure. Since we plan to gradually drop multiapi package started from May as planned before with @kairu-ms, azure cli could drop the build script which is for multiapi in short future.