Skip to content

[AKS] Fix #31265: az aks enable-addons: Fix UnboundLocalError when setting specific dataCollectionSettings #31400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 2 commits into from
May 12, 2025
Merged

[AKS] Fix #31265: az aks enable-addons: Fix UnboundLocalError when setting specific dataCollectionSettings #31400

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e78a33
fix bug
ganga1980 May 2, 2025
db55c07
fix bug
ganga1980 May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/azure-cli/azure/cli/command_modules/acs/addonconfiguration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,11 +770,11 @@ def create_data_collection_endpoint(cmd, subscription, resource_group, region, e
def validate_data_collection_settings(dataCollectionSettings):
if 'interval' in dataCollectionSettings.keys():
intervalValue = dataCollectionSettings["interval"]
if (bool(re.match(r'^[0-9]+[m]$', intervalValue))) is False: # pylint: disable=used-before-assignment
raise InvalidArgumentValueError('interval format must be in <number>m')
intervalValue = int(intervalValue.rstrip("m"))
if intervalValue <= 0 or intervalValue > 30:
raise InvalidArgumentValueError('interval value MUST be in the range from 1m to 30m')
if (bool(re.match(r'^[0-9]+[m]$', intervalValue))) is False: # pylint: disable=used-before-assignment
Comment thread
FumingZhang marked this conversation as resolved.
raise InvalidArgumentValueError('interval format must be in <number>m')
intervalValue = int(intervalValue.rstrip("m"))
if intervalValue <= 0 or intervalValue > 30:
raise InvalidArgumentValueError('interval value MUST be in the range from 1m to 30m')
if 'namespaceFilteringMode' in dataCollectionSettings.keys():
namespaceFilteringModeValue = dataCollectionSettings["namespaceFilteringMode"].lower()
if namespaceFilteringModeValue not in ["off", "exclude", "include"]:
Expand Down
Loading