[App Service] az functionapp plan update: Add zone redundant update support for Flex#31415
Merged
zhoxing-ms merged 2 commits intoAzure:devfrom May 12, 2025
Merged
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @khkh-ms, |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
khkh-ms
force-pushed
the
khkh-flex-zone-redundant-plan
branch
from
0550ae6 to
8018eec
Compare
kamperiadis
reviewed
May 9, 2025
Comment on lines
+5027
to
+5038
| def update_flex_app_service_plan(instance): | ||
| instance.target_worker_count=None | ||
| instance.target_worker_size=None | ||
| instance.is_xenon=None | ||
| instance.hyper_v=None | ||
| instance.per_site_scaling=None | ||
| instance.maximum_elastic_worker_count=None | ||
| instance.elastic_scale_enabled=None | ||
| instance.is_spot=None | ||
| instance.target_worker_size_id=None | ||
| instance.sku.capacity=None | ||
| return instance |
Contributor
There was a problem hiding this comment.
Should we also set these when we create the flex plan?
Contributor
Author
There was a problem hiding this comment.
The backend doesn't expect the full plan object at the moment. During the creation, we don't send the full plan object, only the selected properties. This change ensures that we also only send the selected properties of the object during the update. This only applies to Flex Plan.
sidkri
approved these changes
May 9, 2025
| number_of_workers = validate_range_of_int_flag('--number-of-workers / --min-instances', | ||
| number_of_workers, min_val=0, max_val=20) | ||
| if is_plan_flex(cmd, instance): | ||
| return update_flex_app_service_plan(instance) |
Member
There was a problem hiding this comment.
The instance here is the requested ServerFarm information from the user right?
Contributor
Author
There was a problem hiding this comment.
Yes, it is done in a separate method. Command ensures that this method get the fully populated object (logic is in command definition). The job of this method is just to modify the object.
zhoxing-ms
approved these changes
May 12, 2025
zhoxing-ms
modified the milestones:
June 2025 (2025-06-03),
Build 2025 (2025-05-19)❗ Breaking change release ❗
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az functionapp plan update
Description
Updating
az functionapp plan updateto add support to update zone redundant for Flex apps.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.