From b2dd503c84b12a8db2d6c2573db2a1af590538ae Mon Sep 17 00:00:00 2001 From: Audunn Baldvinsson Date: Tue, 6 May 2025 22:35:58 +0000 Subject: [PATCH 1/2] remove breaking changes properties --- .../cli/command_modules/netappfiles/custom.py | 64 ------------------- 1 file changed, 64 deletions(-) diff --git a/src/azure-cli/azure/cli/command_modules/netappfiles/custom.py b/src/azure-cli/azure/cli/command_modules/netappfiles/custom.py index 70e61aa4122..5f6cec86c4e 100644 --- a/src/azure-cli/azure/cli/command_modules/netappfiles/custom.py +++ b/src/azure-cli/azure/cli/command_modules/netappfiles/custom.py @@ -318,13 +318,6 @@ def _build_arguments_schema(cls, *args, **kwargs): # The API does only support setting Basic and Standard args_schema.network_features.enum = AAZArgEnum({"Basic": "Basic", "Standard": "Standard"}, case_sensitive=False) - # For backwards compat, in next breaking change window, those will be removed - args_schema.is_restoring = AAZBoolArg( - options=["--is-restoring"], - arg_group="Properties", - help="Restoring. Deprecated, do not use will be removed in future version.", - ) - return args_schema def pre_operations(self): @@ -421,63 +414,6 @@ def _build_arguments_schema(cls, *args, **kwargs): maximum=2457600, minimum=50 ) - - # For backwards compat, in next breaking change window, those will be removed - args_schema.avs_data_store = AAZStrArg( - options=["--avs-data-store"], - arg_group="Properties", - help="Specifies whether the volume is enabled for Azure VMware Solution (AVS) datastore purpose. Deprecated, do not use will be removed in future version.", - nullable=True, - enum={"Disabled": "Disabled", "Enabled": "Enabled"}, - ) - args_schema.creation_token = AAZStrArg( - options=["--creation-token"], - arg_group="Properties", - help="A unique file path for the volume. Used when creating mount targets", - fmt=AAZStrArgFormat( - pattern="^[a-zA-Z][a-zA-Z0-9\\-]{0,79}$", - max_length=80, - min_length=1, - ), - ) - args_schema.is_large_volume = AAZBoolArg( - options=["--is-large-volume"], - arg_group="Properties", - help="Specifies whether volume is a Large Volume or Regular Volume.", - nullable=True, - ) - args_schema.is_restoring = AAZBoolArg( - options=["--is-restoring"], - arg_group="Properties", - help="Restoring", - nullable=True, - ) - args_schema.ldap_enabled = AAZBoolArg( - options=["--ldap-enabled"], - arg_group="Properties", - help="Specifies whether LDAP is enabled or not for a given NFS volume.", - nullable=True, - ) - args_schema.network_features = AAZStrArg( - options=["--network-features"], - arg_group="Properties", - help="Basic network, or Standard features available to the volume. hide me", - nullable=True, - enum={"Basic": "Basic", "Basic_Standard": "Basic_Standard", "Standard": "Standard", "Standard_Basic": "Standard_Basic"}, - ) - args_schema.security_style = AAZStrArg( - options=["--security-style"], - arg_group="Properties", - help="The security style of volume, default unix, defaults to ntfs for dual protocol or CIFS protocol", - nullable=True, - enum={"ntfs": "ntfs", "unix": "unix"}, - ) - args_schema.volume_type = AAZStrArg( - options=["--volume-type"], - arg_group="Properties", - help="What type of volume is this. For destination volumes in Cross Region Replication, set type to DataProtection", - nullable=True, - ) return args_schema def pre_operations(self): From 6f700521c871cf9dbcc03032b567fd9ae13f5cc6 Mon Sep 17 00:00:00 2001 From: Audunn Baldvinsson Date: Wed, 7 May 2025 09:16:45 +0000 Subject: [PATCH 2/2] Style --- src/azure-cli/azure/cli/command_modules/netappfiles/custom.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/azure-cli/azure/cli/command_modules/netappfiles/custom.py b/src/azure-cli/azure/cli/command_modules/netappfiles/custom.py index 5f6cec86c4e..4ce0b6c0832 100644 --- a/src/azure-cli/azure/cli/command_modules/netappfiles/custom.py +++ b/src/azure-cli/azure/cli/command_modules/netappfiles/custom.py @@ -402,7 +402,7 @@ def pre_operations(self): class VolumeUpdate(_VolumeUpdate): @classmethod def _build_arguments_schema(cls, *args, **kwargs): - from azure.cli.core.aaz import AAZIntArgFormat, AAZStrArg, AAZStrArgFormat, AAZBoolArg + from azure.cli.core.aaz import AAZIntArgFormat, AAZStrArg args_schema = super()._build_arguments_schema(*args, **kwargs) args_schema.vnet = AAZStrArg( options=["--vnet"],