[ACR] az acr create: Fix logs for domain name label#31423
Merged
zhoxing-ms merged 9 commits intoAzure:devfrom May 21, 2025
Merged
[ACR] az acr create: Fix logs for domain name label#31423zhoxing-ms merged 9 commits intoAzure:devfrom
az acr create: Fix logs for domain name label#31423zhoxing-ms merged 9 commits intoAzure:devfrom
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @trisavo-msft, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
JXavierMSFT,
northtyphoon,
rosanch,
shizhMSFT,
terencet-dev,
toddysm and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
savaradh
reviewed
May 8, 2025
trisavo-msft
changed the title
az acr create: Consolidate logs for domain name label scopeaz acr create: Fix logs for domain name label, refactor valiate_registry_name
savaradh
suggested changes
May 9, 2025
| raise | ||
| login_server = '{}{}{}'.format( | ||
| registry_name, '-{}'.format(tenant_suffix) if tenant_suffix else '', login_server_suffix).lower() | ||
| login_server = '{}{}{}{}'.format( |
Member
There was a problem hiding this comment.
login_server should always be fetched from the registry.login_server parameter. Let us not try to construct it. We can raise an exception and not proceed further if login_server is None
| cli_ctx = cmd.cli_ctx | ||
| resource_not_found, registry = None, None | ||
| try: | ||
| if cli_ctx is None or registry_name is None: |
Member
There was a problem hiding this comment.
It should be registry_name. However we can remove this code. See comment below. We should not try to recreate login_server from the dnl hash and suffix. Just raise an exception
This reverts commit 429a153.
trisavo-msft
changed the title
az acr create: Fix logs for domain name label, refactor valiate_registry_nameaz acr create: Fix logs for domain name label
zhoxing-ms
previously approved these changes
May 12, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
savaradh
approved these changes
May 12, 2025
zhoxing-ms
approved these changes
May 15, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Modify logs for customers using az login domain name label
Testing Guide
Tested locally using venv
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureaz acr login: Modify logs for domain name label on az loginThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.