[App Service] az functionapp create: Add the --domain-name-scope support#31445
Closed
[App Service] az functionapp create: Add the --domain-name-scope support#31445
az functionapp create: Add the --domain-name-scope support#31445Conversation
khkh-ms
requested review from
bebound,
calvinhzy,
evelyn-ys,
jiasli,
jsntcy,
kairu-ms,
necusjz,
yanzhudd and
zhoxing-ms
as code owners
❌AzureCLI-FullTest
|
|
Hi @khkh-ms, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| functionapp create | cmd functionapp create added parameter auto_generated_domain_name_label_scope |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
khkh-ms
changed the title
az functionapp create: Add the --domain-name-scope supportaz functionapp create: Add the --domain-name-scope support
zhoxing-ms
reviewed
May 26, 2025
| help='Enable zone redundancy for high availability. Applies to Flex Consumption SKU only.', is_preview=True) | ||
| c.argument('configure_networking_later', options_list=['--configure-networking-later', '--cnl'], arg_type=get_three_state_flag(), | ||
| help='Use this option if you want to configure networking later for an app using network-restricted storage.') | ||
| c.argument('auto_generated_domain_name_label_scope', options_list=['--domain-name-scope'], help="Specify the scope of uniqueness for the default hostname during resource creation. ", choices=['TenantReuse', 'SubscriptionReuse', 'ResourceGroupReuse', 'NoReuse']) |
Contributor
There was a problem hiding this comment.
May I ask if these valid values can be obtained from Python SDK?
Contributor
|
Could you please resolve these conflicts? |
zhoxing-ms
reviewed
May 26, 2025
Comment on lines
5254
to
+5329
|
|
||
| site_config = SiteConfig(app_settings=[]) | ||
| settings = [] | ||
| site_config = SiteConfig(app_settings=settings) |
Contributor
There was a problem hiding this comment.
What is the difference in this code change? I don't see that settings being used in the later part
Contributor
|
@khkh-ms please note that Azure CLI will have a code freeze on 05/27/2025 07:00 UTC for the upcoming release. Please address these comments ASAP, otherwise it has to be postponed to next sprint (07-01). |
khkh-ms
force-pushed
the
khkh-functionapp-unique-domain
branch
from
94fed1b to
e97456f
Compare
Contributor
|
@khkh-ms Any update? |
Contributor
|
please note that Azure CLI will have a code freeze on 06/24/2025 07:00 UTC for the upcoming release. Please address this conflict ASAP, otherwise it has to be postponed to next sprint (08-05). |
khkh-ms
changed the title
az functionapp create: Add the --domain-name-scope supportaz functionapp create: Add the --domain-name-scope support
khkh-ms
force-pushed
the
khkh-functionapp-unique-domain
branch
from
eb70892 to
faaee45
Compare
Contributor
|
@khkh-ms Could you please resolve these CI issues and conflicts？ |
Contributor
|
Please note that Azure CLI will freeze the code on 07/29/2025 07:00 UTC for the upcoming release. If you want to catch this release train, please resolve these comments ASAP, otherwise this PR has to be postponed to next sprint. |
zhoxing-ms
modified the milestones:
August 2025 (2025-08-05),
September 2025 (2025-09-02)
Contributor
|
please note that the code completion date for the upcoming release is 08/26/2025 at 07:00 UTC. If you want to catch this release train, please address the comments ASAP, otherwise it has to be postponed to next sprint (10/14). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az functionapp create
Description
The change adds the support of --domain-name-scope parameter. The parameter helps customers to specify the domain name scope for the function app. When creating the function app with
--domain-name-scope SubscriptionReuse, it will functionapp with the domain of the format of [appnames]-[unique-string].[region].azurewebsites.net instead of the default domain of [appnames].azurewebsites.net.Testing Guide
az functionapp create -g [resrouce-group] -n [functionapp-name] -s [storage-account-name] --functions-version 4 --runtime python --runtime-version 3.11 --flexconsumption-location [region] --domain-name-scope SubscriptionReuse
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.