-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[App Service] az functionapp create: Add the --domain-name-scope support
#31445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
679e98b
dddd138
fa5896c
7d17854
7fafb00
4fb7754
faaee45
c2501a2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,10 @@ __pycache__/ | |
| # Virtual environment | ||
| env/ | ||
| env27/ | ||
| ienv/ | ||
| iienv/ | ||
| iiienv/ | ||
| vvenv/ | ||
| venv/ | ||
| .python-version | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5232,7 +5232,8 @@ def create_functionapp(cmd, resource_group_name, name, storage_account, plan=Non | |
| always_ready_instances=None, maximum_instance_count=None, instance_memory=None, | ||
| flexconsumption_location=None, deployment_storage_name=None, | ||
| deployment_storage_container_name=None, deployment_storage_auth_type=None, | ||
| deployment_storage_auth_value=None, zone_redundant=False, configure_networking_later=None): | ||
| deployment_storage_auth_value=None, zone_redundant=False, configure_networking_later=None, | ||
| auto_generated_domain_name_label_scope=None): | ||
| # pylint: disable=too-many-statements, too-many-branches | ||
|
|
||
| if functions_version is None and flexconsumption_location is None: | ||
|
|
@@ -5324,7 +5325,8 @@ def create_functionapp(cmd, resource_group_name, name, storage_account, plan=Non | |
|
|
||
| disable_app_insights = disable_app_insights == "true" | ||
|
|
||
| site_config = SiteConfig(app_settings=[]) | ||
| settings = [] | ||
| site_config = SiteConfig(app_settings=settings) | ||
|
Comment on lines
5327
to
+5329
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the difference in this code change? I don't see that |
||
| client = web_client_factory(cmd.cli_ctx) | ||
|
|
||
| if vnet or subnet: | ||
|
|
@@ -5363,7 +5365,8 @@ def create_functionapp(cmd, resource_group_name, name, storage_account, plan=Non | |
|
|
||
| functionapp_def = Site(location=None, site_config=site_config, tags=tags, | ||
| virtual_network_subnet_id=subnet_resource_id, https_only=https_only, | ||
| vnet_route_all_enabled=vnet_route_all_enabled) | ||
| vnet_route_all_enabled=vnet_route_all_enabled, | ||
| auto_generated_domain_name_label_scope=auto_generated_domain_name_label_scope) | ||
|
|
||
| plan_info = None | ||
| if runtime is not None: | ||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask if these valid values can be obtained from Python SDK?