Skip to content

[ACR] remove check for _utils (DO NOT MERGE) #31477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msyyc wants to merge 3 commits into from
Closed

[ACR] remove check for _utils (DO NOT MERGE) #31477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d236856
remove public preview
trisavo-msft May 14, 2025
c53ded7
remove check for _utils
msyyc May 15, 2025
9438d66
Merge branch 'trisavo/connected-registry-ga' of https://github.com/tr…
msyyc May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build_scripts/windows/scripts/patch_models_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ def find_models_to_change(module_name):
return [
importlib.import_module('.'+label+'.models', main_module.__name__)
for (_, label, ispkg) in pkgutil.iter_modules(main_module.__path__)
if ispkg and label != 'aio' and label != '_utils'
if ispkg and label != 'aio'
]


Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/acr/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ def load_command_table(self, _):
g.show_command('show', 'show_encryption')
g.command('rotate-key', "rotate_key")

with self.command_group('acr connected-registry', acr_connected_registry_util, is_preview=True) as g:
with self.command_group('acr connected-registry', acr_connected_registry_util) as g:
Copy link
Copy Markdown
Member

@jiasli jiasli May 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change expected?

Copy link
Copy Markdown
Contributor

@zhoxing-ms zhoxing-ms May 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, please do not add any unrelated logic to this PR, thanks. @msyyc
Then maybe we can modify this title from [ACR] to {ACR}, because this is not perceived by customers

Copy link
Copy Markdown
Contributor

@zhoxing-ms zhoxing-ms May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be merged by this PR https://github.com/Azure/azure-cli/pull/31475/files

g.command('create', 'acr_connected_registry_create')
g.command('delete', 'acr_connected_registry_delete')
g.show_command('show', 'acr_connected_registry_show')
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/requirements.py3.Darwin.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ azure-mgmt-cdn==12.0.0
azure-mgmt-cognitiveservices==13.5.0
azure-mgmt-compute==34.1.0
azure-mgmt-containerinstance==10.2.0b1
azure-mgmt-containerregistry==14.0.0
azure-mgmt-containerregistry==14.1.0b1
azure-mgmt-containerservice==35.0.0
azure-mgmt-core==1.5.0
azure-mgmt-cosmosdb==9.7.0
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/requirements.py3.Linux.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ azure-mgmt-cdn==12.0.0
azure-mgmt-cognitiveservices==13.5.0
azure-mgmt-compute==34.1.0
azure-mgmt-containerinstance==10.2.0b1
azure-mgmt-containerregistry==14.0.0
azure-mgmt-containerregistry==14.1.0b1
azure-mgmt-containerservice==35.0.0
azure-mgmt-core==1.5.0
azure-mgmt-cosmosdb==9.7.0
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/requirements.py3.windows.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ azure-mgmt-cdn==12.0.0
azure-mgmt-cognitiveservices==13.5.0
azure-mgmt-compute==34.1.0
azure-mgmt-containerinstance==10.2.0b1
azure-mgmt-containerregistry==14.0.0
azure-mgmt-containerregistry==14.1.0b1
azure-mgmt-containerservice==35.0.0
azure-mgmt-core==1.5.0
azure-mgmt-cosmosdb==9.7.0
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
'azure-mgmt-cognitiveservices~=13.5.0',
'azure-mgmt-compute~=34.1.0',
'azure-mgmt-containerinstance==10.2.0b1',
'azure-mgmt-containerregistry==14.0.0',
'azure-mgmt-containerregistry==14.1.0b1',
'azure-mgmt-containerservice~=35.0.0',
'azure-mgmt-cosmosdb==9.7.0',
'azure-mgmt-databoxedge~=1.0.0',
Expand Down