{Keyvault} Remove azure stack logic#31517
Merged
Conversation
evelyn-ys
requested review from
bebound,
calvinhzy,
jiasli,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @evelyn-ys, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes all logic related to Azure Stack profiles from the Keyvault module following the deprecation of Azure Stack. Key changes include:
- Removal of the helper function (_azure_stack_wrapper) and all conditional checks related to Azure Stack.
- Updates to command registration and client factory logic to reflect the shift away from Azure Stack.
- Simplification of API version handling in completers and parameter contexts.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/keyvault/custom.py | Removed Azure Stack–specific conditional logic and refactored calls to directly use sdk_no_wait. |
| src/azure-cli/azure/cli/command_modules/keyvault/commands.py | Removed conditional command group registrations based on Azure Stack profile. |
| src/azure-cli/azure/cli/command_modules/keyvault/_params.py | Removed Azure Stack–specific parameter adjustments. |
| src/azure-cli/azure/cli/command_modules/keyvault/_completers.py | Updated API version management by eliminating former Azure Stack checks. |
| src/azure-cli/azure/cli/command_modules/keyvault/_client_factory.py | Removed the is_azure_stack_profile helper function and adjusted API client creation accordingly. |
| src/azure-cli-core/azure/cli/core/profiles/_shared.py | Updated default API versions for several resource types to remove legacy Azure Stack values. |
calvinhzy
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az keyvaultDescription
Since we have dropped azure stack profiles in #31307, we should also clear the logic for azure stack handling in Keyvault module
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.