-
Notifications
You must be signed in to change notification settings - Fork 3.4k
{AI} Test Github Copilot PR review #31522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -813,7 +813,6 @@ def capture_vm(cmd, resource_group_name, vm_name, vhd_name_prefix, | |||||
| output = getattr(result, 'output', None) or result.resources[0] | ||||||
| print(json.dumps(output, indent=2)) # pylint: disable=no-member | ||||||
|
|
||||||
|
|
||||||
| # pylint: disable=too-many-locals, unused-argument, too-many-statements, too-many-branches, broad-except | ||||||
| def create_vm(cmd, vm_name, resource_group_name, image=None, size='Standard_DS1_v2', location=None, tags=None, | ||||||
| no_wait=False, authentication_type=None, admin_password=None, computer_name=None, | ||||||
|
|
@@ -851,6 +850,12 @@ def create_vm(cmd, vm_name, resource_group_name, image=None, size='Standard_DS1_ | |||||
| exclude_zones=None, align_regional_disks_to_vm_zone=None, wire_server_mode=None, imds_mode=None, | ||||||
| wire_server_access_control_profile_reference_id=None, imds_access_control_profile_reference_id=None, | ||||||
| key_incarnation_id=None): | ||||||
| i = 8808 | ||||||
| j = 8809 | ||||||
|
||||||
| j = 8809 |
Copilot
AI
May 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of a hard-coded number for 'test_port' can make future maintenance more challenging. Consider parameterizing this value or adding inline documentation to clarify its purpose.
| test_port = 8810 | |
| test_port = DEFAULT_TEST_PORT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable 'i' with a hard-coded number appears to be a placeholder or testing artifact. Consider renaming or removing it if it is not intended for production use.