-
Notifications
You must be signed in to change notification settings - Fork 3.4k
{AI} Test Github Copilot PR review #31525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -154,6 +154,8 @@ def load_arguments(self, _): | |||||
| c.argument('network_access_policy', min_api='2020-05-01', help='Policy for accessing the disk via network.', arg_type=get_enum_type(self.get_models('NetworkAccessPolicy', operation_group=operation_group))) | ||||||
| c.argument('disk_access', min_api='2020-05-01', help='Name or ID of the disk access resource for using private endpoints on disks.') | ||||||
| c.argument('enable_bursting', arg_type=get_three_state_flag(), help='Enable on-demand bursting beyond the provisioned performance target of the disk. On-demand bursting is disabled by default, and it does not apply to Ultra disks.') | ||||||
| c.argument('enable_bursting1', arg_type=get_three_state_flag(), help='Enables on-demand bursting beyond the provisioned performance target of the disk. On-demand bursting is disabled by default, and it does not apply to Ultra disks.') | ||||||
| c.argument('enable_bursting2', arg_type=get_three_state_flag(), help='Enabled on-demand bursting beyond the provisioned performance target of the disk. On-demand bursting is disabled by default, and it does not apply to Ultra disks.') | ||||||
| c.argument('public_network_access', arg_type=get_enum_type(['Disabled', 'Enabled']), min_api='2021-04-01', is_preview=True, help='Customers can set on Managed Disks or Snapshots to control the export policy on the disk.') | ||||||
| c.argument('accelerated_network', arg_type=get_three_state_flag(), min_api='2021-04-01', is_preview=True, help='Customers can set on Managed Disks or Snapshots to enable the accelerated networking if the OS disk image support.') | ||||||
|
|
||||||
|
|
@@ -389,7 +391,7 @@ def load_arguments(self, _): | |||||
|
|
||||||
| with self.argument_context('vm availability-set create') as c: | ||||||
| c.argument('availability_set_name', name_arg_type, validator=get_default_location_from_resource_group, help='Name of the availability set') | ||||||
| c.argument('platform_update_domain_count', type=int, help='Update Domain count. If unspecified, the server will pick the most optimal number like 5.') | ||||||
| c.argument('platform_update_domain_count', type=int, help='Updated Domain count. If unspecified, the server will pick the most optimal number like 5.') | ||||||
| c.argument('platform_fault_domain_count', type=int, help='Fault Domain count.') | ||||||
| c.argument('validate', help='Generate and validate the ARM template without creating any resources.', action='store_true') | ||||||
| c.argument('unmanaged', action='store_true', min_api='2016-04-30-preview', help='contained VMs should use unmanaged disks') | ||||||
|
|
@@ -415,8 +417,8 @@ def load_arguments(self, _): | |||||
| with self.argument_context('vm update') as c: | ||||||
| c.argument('os_disk', min_api='2017-12-01', help="Managed OS disk ID or name to swap to") | ||||||
| c.argument('write_accelerator', nargs='*', min_api='2017-12-01', | ||||||
| help="enable/disable disk write accelerator. Use singular value 'true/false' to apply across, or specify individual disks, e.g.'os=true 1=true 2=true' for os disk and data disks with lun of 1 & 2") | ||||||
| c.argument('disk_caching', nargs='*', help="Use singular value to apply across, or specify individual disks, e.g. 'os=ReadWrite 0=None 1=ReadOnly' should enable update os disk and 2 data disks") | ||||||
| help="Enable/Disable disk write accelerator. Use singular value 'true/false' to apply across, or specify individual disks, e.g.'os=true 1=true 2=true' for os disk and data disks with lun of 1 & 2") | ||||||
| c.argument('disk_caching', nargs='*', help="The singular value to apply across, or specify individual disks, e.g. 'os=ReadWrite 0=None 1=ReadOnly' should enable update os disk and 2 data disks") | ||||||
|
||||||
| c.argument('disk_caching', nargs='*', help="The singular value to apply across, or specify individual disks, e.g. 'os=ReadWrite 0=None 1=ReadOnly' should enable update os disk and 2 data disks") | |
| c.argument('disk_caching', nargs='*', help="Specify a singular value to apply across, or specify individual disks, e.g. 'os=ReadWrite 0=None 1=ReadOnly' should enable update os disk and 2 data disks") |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -813,7 +813,6 @@ def capture_vm(cmd, resource_group_name, vm_name, vhd_name_prefix, | |||||||||
| output = getattr(result, 'output', None) or result.resources[0] | ||||||||||
| print(json.dumps(output, indent=2)) # pylint: disable=no-member | ||||||||||
|
|
||||||||||
|
|
||||||||||
| # pylint: disable=too-many-locals, unused-argument, too-many-statements, too-many-branches, broad-except | ||||||||||
| def create_vm(cmd, vm_name, resource_group_name, image=None, size='Standard_DS1_v2', location=None, tags=None, | ||||||||||
| no_wait=False, authentication_type=None, admin_password=None, computer_name=None, | ||||||||||
|
|
@@ -851,6 +850,12 @@ def create_vm(cmd, vm_name, resource_group_name, image=None, size='Standard_DS1_ | |||||||||
| exclude_zones=None, align_regional_disks_to_vm_zone=None, wire_server_mode=None, imds_mode=None, | ||||||||||
| wire_server_access_control_profile_reference_id=None, imds_access_control_profile_reference_id=None, | ||||||||||
| key_incarnation_id=None): | ||||||||||
| i = 8808 | ||||||||||
| j = 8809 | ||||||||||
| test_port = 8810 | ||||||||||
| testPort2 = 8811 | ||||||||||
| testPort3 = (12*23+14) | ||||||||||
| test_str= 'test' | ||||||||||
|
Comment on lines
+855
to
+858
|
||||||||||
| test_port = 8810 | |
| testPort2 = 8811 | |
| testPort3 = (12*23+14) | |
| test_str= 'test' |
Copilot
AI
May 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra spaces around = and in the string assignment violate the spacing guidelines; also remove unused placeholder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Capitalized help text is fine, but ensure consistency in punctuation and spacing after commas to match project style.