Conversation
️✔️AzureCLI-FullTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Hi @audunn, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| netappfiles volume-group create | cmd netappfiles volume-group create added parameter binary_size |
||
| netappfiles volume-group create | cmd netappfiles volume-group create added parameter binary_throughput |
||
| netappfiles volume-group create | cmd netappfiles volume-group create added parameter database_size |
||
| netappfiles volume-group create | cmd netappfiles volume-group create added parameter database_throughput |
||
| netappfiles volume-group create | cmd netappfiles volume-group create added parameter log_mirror_size |
||
| netappfiles volume-group create | cmd netappfiles volume-group create added parameter log_mirror_throughput |
||
| netappfiles volume-group create | cmd netappfiles volume-group create added parameter number_of_oracle_volumes |
microsoft-github-policy-service
bot
requested review from
jiasli,
kairu-ms and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for Oracle volume groups in the NetApp Files CLI by extending both the command schema and the tests.
- Added new CLI arguments and validation for Oracle-specific sizing and volume counts
- Updated
pre_operationsand volume-creation helpers to handle Oracle volume types - Expanded and refactored tests (
test_volumegroup_commands.py) to cover Oracle scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/latest/test_volumegroup_commands.py | Added test_oracle_volume_groups, updated flags and cleanup for Oracle tests |
| command_modules/netappfiles/custom.py | Introduced Oracle sizing args, validation, and helper logic for Oracle volumes |
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/test_volumegroup_commands.py:110
- The create command is missing the
--volume-group-name(or--group-name) flag, so the test will not supply the volume-group name and likely fail.
--zones {zones} --application-identifier {application_identifier} --application-type {application_type} -l {loc} --add-snapshot-capacity {add_snap_cap} --database-size {size} --database-throughput 120 --number-of-volumes 3
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31528 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31528 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
Not sure why it is failing PR title for not having starting with |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31528 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
kairu-ms
changed the title
az netappfiles volume-group create: Add support for Oracle in ANF Volume Groups
kairu-ms
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az netappfiles volume-group
Description
Adds support for Oracle Volume Groups
Testing Guide
History Notes
[NetAppFiles]
az netappfiles volume-group create: Add support for Oracle in ANF Volume GroupsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.