{Network} StandardV2 for NAT Gateway and Public IP#31532
Merged
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @cxznmhdcxz, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network public-ip prefix create | cmd network public-ip prefix create added parameter sku |
||
| network public-ip update | cmd network public-ip update update parameter sku: updated property choices from ['Basic', 'Standard'] to ['Basic', 'Standard', 'StandardV2'] |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
AllyW,
jsntcy,
kairu-ms,
necusjz and
yonzhan
microsoft-github-policy-service
bot
added
the
Network
cxznmhdcxz
force-pushed
the
standardV2-for-nat-gateway-and-public-ip
branch
from
70d8616 to
8b4af1b
Compare
cxznmhdcxz
requested review from
FumingZhang,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates network commands to API version 2024-07-01, adds StandardV2 SKU support, and introduces IPv6 and source virtual network properties across NAT gateway, Public IP, and Public IP prefix commands.
- Bump all relevant API-version strings from 2022-09-01/2022-11-01/2022-01-01 to 2024-07-01
- Add enums for StandardV2 SKU and CLI arguments for IPv6 addresses/prefixes and sourceVirtualNetwork
- Update schema and helper methods to include
public_ip_addresses_v6,public_ip_prefixes_v6,source_virtual_network, and mark new read-only flags - Fix resource group vs. subscription scope logic in list commands
- Update test recordings to use the new API version
Reviewed Changes
Copilot reviewed 141 out of 141 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| public_ip/prefix/_show.py | API version bump & added v6 and sourceVirtualNetwork |
| public_ip/prefix/_list.py | Listing logic fix, API bump & added v6 properties |
| public_ip/prefix/_create.py, _update.py | New StandardV2 enum, IPv6 args & sourceVirtualNetwork |
| network/public_ip/_create.py, _update.py | StandardV2 SKU, IPv6 args, schema updates |
| network/nat/gateway/_create.py, _update.py | StandardV2 SKU, IPv6 args, sub-resource helpers |
| Tests: monitor & acs recording YAMLs | Updated api-version strings |
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/public_ip/prefix/_create.py:142
- Tests for the new
StandardV2SKU should be added to verify correct CLI behavior and generated ARM templates when this SKU is selected.
enum={"Standard": "Standard", "StandardV2": "StandardV2"},
src/azure-cli/azure/cli/command_modules/monitor/tests/latest/recordings/test_monitor_clone_public_ip_metric_alerts_scenario.yaml:69
- [nitpick] Manual API-version updates across many recording files are error-prone; consider centralizing the version in a constant or template to simplify future bumps.
uri: https://management.azure.com/.../publicIPAddresses/ip1?api-version=2024-07-01
| ) | ||
| nat_gateway.public_ip_prefixes_v6 = AAZListArg( | ||
| options=["public-ip-prefixes-v6"], | ||
| help="An array of public ip prefixes V6 associated with the nat gateway resource.", |
There was a problem hiding this comment.
[nitpick] Consider using the standard term 'IPv6' instead of 'V6' for clarity, e.g., "An array of IPv6 public IP prefixes associated with the NAT gateway."
Suggested change
| help="An array of public ip prefixes V6 associated with the nat gateway resource.", | |
| help="An array of public IPv6 prefixes associated with the nat gateway resource.", |
Comment on lines
+54
to
+58
| condition_0 = has_value(self.ctx.subscription_id) and has_value(self.ctx.args.resource_group) is not True | ||
| condition_1 = has_value(self.ctx.args.resource_group) and has_value(self.ctx.subscription_id) | ||
| if condition_0: | ||
| self.PublicIPPrefixesList(ctx=self.ctx)() | ||
| if condition_1: | ||
| self.PublicIPPrefixesListAll(ctx=self.ctx)() | ||
| if condition_1: |
There was a problem hiding this comment.
[nitpick] The naming of condition_0/condition_1 is not descriptive; consider renaming to is_tenant_scope and is_rg_scope (or similar) to clarify their intent.
necusjz
changed the title
necusjz
approved these changes
May 29, 2025
zhoxing-ms
approved these changes
May 29, 2025
|
@necusjz @cxznmhdcxz - We need to push out when we publish these changes. GA is now delayed and will no longer make June 30 target date. I'm working on getting new GA date, can update as soon as I know. Thanks |
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az network nat gateway create/delete/list/show/updateaz network public-ip create/delete/list/show/updateaz network public-ip prefix create/delete/list/show/updateDescription
resolve #31245
aaz Azure/aaz#772
Testing Guide
History Notes
[Network]
az network nat gateway: Support Standard V2 SKU[Network]
az network public-ip: Support Standard V2 SKU[Network]
az network public-ip prefix: Support Standard V2 SKUThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.