[Mysql] az mysql flexible-server create: Change default storage redundancy for BC SKU to local redundancy#31536
Closed
[Mysql] az mysql flexible-server create: Change default storage redundancy for BC SKU to local redundancy#31536
az mysql flexible-server create: Change default storage redundancy for BC SKU to local redundancy#31536Conversation
…HA-limitations
️✔️AzureCLI-FullTest
|
|
Hi @linyudoa, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
customer-reported
Contributor
|
Thank you for your contribution @linyudoa! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MySQL flexible-server commands to change the default storage redundancy for Business Critical SKUs to local redundancy and introduces new parameters for backup intervals and faster I/O scaling during restore and replica operations.
- Add
--backup-intervaltoflexible-server createand include it in the backup model. - Introduce
--faster-restoreand--faster-provisioningflags and corresponding logic to toggle auto IOPS scaling. - Remove tier-based branching in storage redundancy validator so Business Critical always uses local redundancy.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/mysql/custom.py | Add backup_interval parameter, faster restore/provision logic, always local redundancy |
| src/azure-cli/azure/cli/command_modules/mysql/_validators.py | Add _mysql_backup_interval_validator for --backup-interval |
| src/azure-cli/azure/cli/command_modules/mysql/_params.py | Define CLI args for --backup-interval, --faster-restore, --faster-provisioning |
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/mysql/custom.py:1679
- The parameter name
faster_restoreis misleading in this provisioning helper. Rename it tofaster_provisioningto match the function’s purpose.
def _determine_auto_io_scaling_by_faster_provisioning(faster_restore):
src/azure-cli/azure/cli/command_modules/mysql/custom.py:374
- The
DbContextconstructor does not accept abackup_intervalargument, so this will raise aTypeError. Remove or relocate this parameter to where it is used (e.g., themodels.Backupinstantiation).
backup_interval=backup_interval,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Mysql]
az mysql flexible-server create: Change default storage redundancy for BC SKU to local redundancyThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.