Conversation
️✔️AzureCLI-FullTest
|
|
Hi @linyudoa, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the default storage redundancy for Flexible Server BC SKU from zone to local by removing the tier-based default logic and always setting storage_redundancy to "LocalRedundancy".
- Removes conditional default for
MemoryOptimizedtier - Unconditionally assigns
"LocalRedundancy" - Simplifies
_determine_storage_redundancylogic
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/mysql/custom.py:1699
- This assignment now overrides any user-specified
storage_redundancyvalue. Consider keeping theif storage_redundancy is Noneguard so that provided values are respected, e.g.:
if storage_redundancy is None:
storage_redundancy = "LocalRedundancy"storage_redundancy = "LocalRedundancy"
src/azure-cli/azure/cli/command_modules/mysql/custom.py:1699
- The
storage_redundancyassignment andreturnshould be indented inside the function body. Ensure these lines are prefixed with four spaces so the code remains valid Python.
storage_redundancy = "LocalRedundancy"
microsoft-github-policy-service
bot
added
the
customer-reported
Contributor
|
Thank you for your contribution @linyudoa! We will review the pull request and get back to you soon. |
evelyn-ys
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Mysql]
az mysql flexible-server create: Change default storage redundancy for BC SKU to local redundancyThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.