Conversation
️✔️AzureCLI-FullTest
|
|
Hi @evelyn-ys, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes all the vendored Key Vault Security Domain SDK code and updates references to use the new external package “azure-keyvault-securitydomain 1.0.0b1”. Key changes include deleting legacy vendored files, updating custom command implementations to use the new SDK’s API (e.g. using skip_activation_polling instead of polling), and modifying client factory imports accordingly.
Reviewed Changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vendored_sdks/* | Entire removal of generated SDK code |
| custom.py | Updated begin_upload and begin_download APIs and return flows to use new SDK parameters |
| _client_factory.py | Updated import references to use the new external SDK |
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/keyvault/custom.py:2313
- Switching from the 'polling' parameter to 'skip_activation_polling' is consistent with the new SDK; please ensure that client.get_upload_status() returns the expected operation status after poller.result().
poller = client.begin_upload(security_domain=security_domain, skip_activation_polling=no_wait)
src/azure-cli/azure/cli/command_modules/keyvault/custom.py:2395
- Renaming the parameter from 'certificate_info_object' to 'certificate_info' and adopting skip_activation_polling should align with the new SDK; please verify that client.get_download_status() returns the proper status consistently.
poller = client.begin_download(certificate_info=certificate_info, skip_activation_polling=no_wait)
There was a problem hiding this comment.
I can't successfully re-record this test because of service maintenance:
(UnavailableDueToMaintenance) This security domain cannot be restored at this time due to necessary service maintenance. For more information, please see https://aka.ms/mhsm/planned-maintenance.
So here I manually updated the yaml file to make test pass
Related command
az keyvault security-domainDescription
SDK team has helped releasing
azure-keyvault-securitydomainSDK, so it's time for us to remove the vendored private SDK.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.