{Core} Remove temporary compatible logic in build script#31555
Merged
zhoxing-ms merged 1 commit intoAzure:devfrom Jun 4, 2025
Merged
{Core} Remove temporary compatible logic in build script#31555zhoxing-ms merged 1 commit intoAzure:devfrom
zhoxing-ms merged 1 commit intoAzure:devfrom
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @zhoxing-ms, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes legacy compatibility logic in the build pipeline and updates the Azure Container Registry management SDK version.
- Bumps
azure-mgmt-containerregistryfrom14.0.0to14.1.0b1insetup.pyand all platform-specific requirement files - Simplifies
find_models_to_changeby no longer excluding the_utilspackage
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/setup.py | Updated azure-mgmt-containerregistry version |
| src/azure-cli/requirements.py3.windows.txt | Updated azure-mgmt-containerregistry version |
| src/azure-cli/requirements.py3.Linux.txt | Updated azure-mgmt-containerregistry version |
| src/azure-cli/requirements.py3.Darwin.txt | Updated azure-mgmt-containerregistry version |
| build_scripts/windows/scripts/patch_models_v2.py | Removed _utils exclusion in model discovery logic |
Comments suppressed due to low confidence (1)
build_scripts/windows/scripts/patch_models_v2.py:248
- By removing the exclusion for '_utils', the utils package will now be processed as a model module even though it may not define models, potentially causing runtime errors. Consider reintroducing an explicit filter for non-model packages or adding tests and documentation to clarify this change.
if ispkg and label != 'aio'
zhoxing-ms
changed the title
huanwu
approved these changes
May 27, 2025
kairu-ms
approved these changes
May 27, 2025
evelyn-ys
approved these changes
May 27, 2025
Contributor
Author
|
@jiasli Could you please help review this PR? |
jiasli
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Replace PR: #31477
Remove the temporary compatibility logic made for SDK issues
Context: https://github.com/Azure/azure-cli/pull/31382/files#r2086267859
SDK issue: Azure/azure-sdk-for-python#41083
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.