{backup} Update recoveryservices SDK to 3.1.0#31596
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
Update the recoveryservices SDK dependency to version 3.1.0 and re-enable live role assignment commands in backup tests.
- Bump
azure-mgmt-recoveryservicesto 3.1.0 in setup and platform-specific requirement files - Un-comment and activate live role assignment commands and assertions in
test_backup_commands.py
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/setup.py | Updated azure-mgmt-recoveryservices from ~=3.0.0 to ~=3.1.0 |
| src/azure-cli/requirements.py3.windows.txt | Updated azure-mgmt-recoveryservices from 3.0.0 to 3.1.0 |
| src/azure-cli/requirements.py3.Linux.txt | Updated azure-mgmt-recoveryservices from 3.0.0 to 3.1.0 |
| src/azure-cli/requirements.py3.Darwin.txt | Updated azure-mgmt-recoveryservices from 3.0.0 to 3.1.0 |
| src/azure-cli/azure/cli/command_modules/backup/tests/latest/test_backup_commands.py | Un-commented live role assignment commands and assertions |
|
CI green, please review. |
| @VaultPreparer(parameter_name='vault1') | ||
| @VaultPreparer(parameter_name='vault2') | ||
| @KeyVaultPreparer(additional_params='--enable-rbac-authorization false') | ||
| @record_only() |
There was a problem hiding this comment.
May I ask why do you need to mark this test as @record_only() ?
There was a problem hiding this comment.
In order to be run the test in recorded/live mode, we have to comment/uncomment some lines that come up later on. Since manual intervention has to be made to run the test in live mode, I've added @record_only()
There was a problem hiding this comment.
My question is why do you want this test skip the live mode testing?
There was a problem hiding this comment.
I do run the live mode testing whenever an API version upgrade happens. If it seems unnecessary though I can remove the @record_only, should I do that?
There was a problem hiding this comment.
After adding the @record_only flag, executing live mode will skip this test
There was a problem hiding this comment.
Ah I see what you meant. I'll revert this bit of code.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Related command
az backupDescription
recoveryservicesSDK updated to 3.1.0. This updates the API version being used for vault calls to 2025-02-01l.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.