[Identity] Fix #31598: Fix regression in az identity federated-credential create by defaulting audience#31609
Merged
zhoxing-ms merged 4 commits intoAzure:devfrom Jun 12, 2025
Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| identity federated-credential create | cmd identity federated-credential create update parameter audiences: added property aaz_default=['api://AzureADTokenExchange'] |
||
| identity federated-credential create | cmd identity federated-credential create update parameter audiences: added property default=['api://AzureADTokenExchange'] |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
|
Thank you for your contribution @Ashish372! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
the
customer-reported
Ashish372
changed the title
az identity federated-credential create/update: by defaulting audience to api://AzureADTokenExchange
Sruuujaaan
approved these changes
Jun 6, 2025
Ashish372
changed the title
az identity federated-credential create/update: by defaulting audience to api://AzureADTokenExchangeaz identity federated-credential create by defaulting audience to api://AzureADTokenExchange
Sruuujaaan
reviewed
Jun 6, 2025
Contributor
|
Could you add some tests for this case? |
zhoxing-ms
approved these changes
Jun 9, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
changed the title
az identity federated-credential create by defaulting audience to api://AzureADTokenExchangeaz identity federated-credential create by defaulting audience
Contributor
Author
@microsoft-github-policy-service agree |
zhoxing-ms
approved these changes
Jun 10, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
This PR fixes a regression in the az identity federated-credential create command, where the audiences parameter lacked a default value. As a result, users were required to manually specify the audience each time.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.