Merged
Conversation
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the live test pipeline scripts to use token-based authentication, parameterizes key settings (storage account, static web URL, branches), and updates the Azure Pipelines YAML to accept parameters and streamline test execution.
- Swapped hardcoded storage/Kusto credentials for DefaultAzureCredential and new
ACCOUNT_NAME/IDENTITY_CLIENT_IDenv vars in Python scripts - Simplified
generate_index.pyby removing blob list parsing, introducingSTATIC_WEB_URL, and consolidating uploads to$web - Converted
CLITest.ymlto parameterized pipeline with userTarget, pythonVersion, parallelism, staticWebUrl, and updated task inputs/timeouts
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/live_test/sendemail.py | Replaced AAD app key auth with token provider, added ACCOUNT_NAME & IDENTITY_CLIENT_ID env vars |
| scripts/live_test/generate_index.py | Removed manual blob list parsing, added STATIC_WEB_URL, refactored generate and render |
| scripts/live_test/clean.py | Invokes clean_resource_group earlier, added print statements for keyvault and resource groups |
| scripts/live_test/CLITest.yml | Introduced pipeline parameters, updated job timeouts/parallelism, and AzureCLI task inputs |
Comments suppressed due to low confidence (2)
scripts/live_test/sendemail.py:43
- The IDENTITY_CLIENT_ID variable is declared but not used anywhere in this file. Consider removing it or integrating it into the authentication flow.
IDENTITY_CLIENT_ID = os.environ.get('IDENTITY_CLIENT_ID')
scripts/live_test/generate_index.py:16
- The module uses
os.environbutosis not imported. Addimport osat the top to avoid a NameError at runtime.
STATIC_WEB_URL = os.environ.get('STATIC_WEB_URL')
|
|
||
|
|
||
| def generate(container, container_url, testdata, USER_REPO, USER_BRANCH, COMMIT_ID, USER_LIVE, USER_TARGET, ACCOUNT_KEY, USER_REPO_EXT, USER_BRANCH_EXT): | ||
| def generate(ACCOUNT_NAME, container, testdata, USER_REPO, USER_BRANCH, COMMIT_ID, USER_LIVE, USER_REPO_EXT, USER_BRANCH_EXT): |
There was a problem hiding this comment.
Function parameter ACCOUNT_NAME is uppercase, but according to coding guidelines parameters should use snake_case. Consider renaming it to account_name.
| <td>{}</td> | ||
| </tr> | ||
| """.format(module, passed, failed, rate, reports) | ||
| """.format('<a href="{}">{}</a> '.format(STATIC_WEB_URL+module+'.report.html', module), |
There was a problem hiding this comment.
Operators + should be surrounded by spaces for readability. Change STATIC_WEB_URL+module+'.report.html' to STATIC_WEB_URL + module + '.report.html'.
wangzelin007
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.