Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network network-watcher packet-capture create | cmd network network-watcher packet-capture create update parameter time_limit_in_seconds: removed property aaz_default=18000 |
||
| network network-watcher packet-capture create | cmd network network-watcher packet-capture create update parameter time_limit_in_seconds: removed property default=18000 |
||
| network network-watcher packet-capture create | cmd network network-watcher packet-capture create update parameter total_bytes_per_session: removed property aaz_default=1073741824 |
||
| network network-watcher packet-capture create | cmd network network-watcher packet-capture create update parameter total_bytes_per_session: removed property default=1073741824 |
||
| network network-watcher packet-capture wait | cmd network network-watcher packet-capture wait removed |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
AllyW,
jsntcy,
kairu-ms,
necusjz and
yonzhan
microsoft-github-policy-service
bot
added
the
Network
v-sapanchal
changed the title
necusjz
changed the title
az network network-watcher packet-capture create: Make ring buffer command working
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes default values for the time-limit and total-bytes parameters in the packet capture create command to support the ring buffer functionality.
- Removed default value for --time-limit-in-seconds
- Removed default value for --total-bytes/--total-bytes-per-session
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/network_watcher/packet_capture/_create.py:116
- [nitpick] Consider adding an inline comment explaining the rationale for removing the default value for --time-limit-in-seconds to help future maintainers understand this change.
default=18000,
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/network_watcher/packet_capture/_create.py:125
- [nitpick] Consider adding an inline comment clarifying the removal of the default value for --total-bytes/--total-bytes-per-session to support continuous-capture scenarios.
default=1073741824,
Contributor
Author
|
Please do not merge it now, need to get reviewed by team and then we are good. |
Contributor
Author
|
Please merge this PR, review part is done. |
necusjz
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az network network-watcher packet-capture create'
Description
Removed the default values from old parameters to make ring buffer command working, as continuous-capture nullable parameter.
Testing Guide
az network network-watcher packet-capture create --network-watcher-name "NetworkWatcher_region" --packet-capture-name "clitestpcap24" --resource-group "RGName" --storage-location '{"storageId":"/subscriptions/SubId/resourceGroups/rg/providers/Microsoft.Storage/storageAccounts/SA"}' --target "/subscriptions/SubId/resourceGroups/rg/providers/Microsoft.Compute/virtualMachineScaleSets/vmssname" --continuous-capture true --capture-settings '{"FileCount":"10","FileSizeInBytes":"102400 ","SessionTimeLimitInSeconds":"100"}'
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.