[Service Fabric] Fix #18358: Fix the bug that az sf client-certificate add fails with remove not defined#31632
Merged
zhoxing-ms merged 1 commit intoAzure:devfrom Jun 23, 2025
Merged
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue in the Service Fabric client-certificate addition command (#18358) by updating the logic for handling certificate common names.
- Update the _add_common_name function to remove existing duplicate entries before appending a new certificate common name
- Replace the ambiguous use of the "remove" variable with a clearer approach
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/servicefabric/custom.py:336
- [nitpick] The variable 'remove' is ambiguous as it starts as a boolean but later holds an object. Consider renaming it to 'cert_to_remove' or 'existing_cert' to clearly indicate its role.
remove = False
microsoft-github-policy-service
bot
added
Service Fabric
iliu816
changed the title
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
changed the title
az sf client-certificate add fails with 'remove' not defined
yanzhudd
changed the title
az sf client-certificate add fails with 'remove' not definedaz sf client-certificate add fails with remove not defined
zhoxing-ms
approved these changes
Jun 23, 2025
zhoxing-ms
changed the title
az sf client-certificate add fails with remove not definedaz sf client-certificate add fails with remove not defined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az sf client-certificate add
Description
Fix #18358
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.