Skip to content

[Service Fabric] Fix #18358: Fix the bug that az sf client-certificate add fails with remove not defined #31632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 1 commit into from
Jun 23, 2025
Merged

[Service Fabric] Fix #18358: Fix the bug that az sf client-certificate add fails with remove not defined #31632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/azure-cli/azure/cli/command_modules/servicefabric/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,13 +333,20 @@ def _add_thumbprint(cluster, is_admin, thumbprint):
ClientCertificateThumbprint(is_admin, thumbprint))

def _add_common_name(cluster, is_admin, certificate_common_name, certificate_issuer_thumbprint):
remove = False
for t in cluster.client_certificate_common_names:
if t.certificate_common_name.lower() == certificate_common_name.lower() and t.certificate_issuer_thumbprint.lower() == certificate_issuer_thumbprint.lower():
remove = t

if remove:
cluster.client_certificate_common_names.remove(remove)
cluster.client_certificate_common_names.add(ClientCertificateCommonName(
is_admin, certificate_common_name, certificate_issuer_thumbprint))

client_certificate_common_name = ClientCertificateCommonName(
is_admin=is_admin,
certificate_common_name=certificate_common_name,
certificate_issuer_thumbprint=certificate_issuer_thumbprint,
)
cluster.client_certificate_common_names.append(client_certificate_common_name)
return cluster.client_certificate_common_names

if thumbprint:
Expand Down
Loading