[App Service] az functionapp create: Change from Cooper#31635
[App Service] az functionapp create: Change from Cooper#31635
az functionapp create: Change from Cooper#31635Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a temporary region-mapping workaround so that certain unsupported Function App locations are remapped to eastus2 before calling the stacks API.
- Introduces an
ifblock to remap"northcentralus(stage)","northcentralusstage", and"eastus2euap"to"eastus2". - Adds surrounding blank lines around the new block.
| if runtime == "dotnet-isolated": | ||
| runtime = "dotnet" | ||
|
|
||
| if location == "northcentralus(stage)" or location == "northcentralusstage" or location == "eastus2euap": |
There was a problem hiding this comment.
[nitpick] Consider simplifying the multiple or conditions by using a membership test with a tuple or set, e.g.: if location in ("northcentralus(stage)", "northcentralusstage", "eastus2euap"):, which is more concise and easier to extend.
| if location == "northcentralus(stage)" or location == "northcentralusstage" or location == "eastus2euap": | |
| if location in ("northcentralus(stage)", "northcentralusstage", "eastus2euap"): |
| 'api-version=2020-10-01&removeHiddenStacks=true&removeDeprecatedStacks=true&stack={}' | ||
| if runtime == "dotnet-isolated": | ||
| runtime = "dotnet" | ||
|
|
There was a problem hiding this comment.
Remove extraneous whitespace-only lines (and any trailing spaces) around the newly added block to adhere to style guidelines and avoid unintended whitespace.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
changed the title
az functionapp create: Changes from Cooperaz functionapp create: Change from Cooper
|
Please note that Azure CLI will have a code freeze on 06/24/2025 07:00 UTC for the upcoming release. If you want to catch this release train, please resolve the CI issue ASAP, otherwise it has to be postponed to next sprint (08-05). |
|
Could you please add some test cases for this PR change? |
|
@khkh-ms Any update? |
|
Please note that Azure CLI will freeze the code on 07/29/2025 07:00 UTC for the upcoming release. If you want to catch this release train, please resolve these comments ASAP, otherwise this PR has to be postponed to next sprint. |
zhoxing-ms
modified the milestones:
August 2025 (2025-08-05),
September 2025 (2025-09-02)
|
please note that the code completion date for the upcoming release is 08/26/2025 at 07:00 UTC. If you want to catch this release train, please address the comments ASAP, otherwise it has to be postponed to next sprint (10/14). |
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.