{Compute} az vm: Migrate commands to CodeGen based#31658
Merged
zhoxing-ms merged 9 commits intoAzure:devfrom Jun 17, 2025
Merged
{Compute} az vm: Migrate commands to CodeGen based#31658zhoxing-ms merged 9 commits intoAzure:devfrom
az vm: Migrate commands to CodeGen based#31658zhoxing-ms merged 9 commits intoAzure:devfrom
Conversation
yanzhudd
requested review from
jsntcy,
wangzelin007 and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vm capture | cmd vm capture added parameter no_wait |
||
| vm capture | cmd vm capture update parameter overwrite: added property aaz_default=True |
||
| vm capture | cmd vm capture update parameter overwrite: added property aaz_type=bool |
||
| vm capture | cmd vm capture update parameter overwrite: added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| vm capture | cmd vm capture update parameter overwrite: added property nargs=? |
||
| vm capture | cmd vm capture update parameter overwrite: added property type=bool |
||
| vm capture | cmd vm capture update parameter resource_group_name: added property aaz_type=string |
||
| vm capture | cmd vm capture update parameter resource_group_name: added property type=string |
||
| vm capture | cmd vm capture update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| vm capture | cmd vm capture update parameter storage_container: added property aaz_default=vhds |
||
| vm capture | cmd vm capture update parameter storage_container: added property aaz_type=string |
||
| vm capture | cmd vm capture update parameter storage_container: added property type=string |
||
| vm capture | cmd vm capture update parameter vhd_name_prefix: added property aaz_type=string |
||
| vm capture | cmd vm capture update parameter vhd_name_prefix: added property type=string |
||
| vm capture | cmd vm capture update parameter vm_name: added property aaz_type=string |
||
| vm capture | cmd vm capture update parameter vm_name: added property type=string |
||
| vm capture | cmd vm capture update parameter vm_name: updated property name from vm_name to name |
||
| vm delete | cmd vm delete removed property confirmation |
||
| vm delete | cmd vm delete update parameter force_deletion: added property aaz_type=bool |
||
| vm delete | cmd vm delete update parameter force_deletion: added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| vm delete | cmd vm delete update parameter force_deletion: added property nargs=? |
||
| vm delete | cmd vm delete update parameter force_deletion: added property type=bool |
||
| vm delete | cmd vm delete update parameter no_wait: added property aaz_type=bool |
||
| vm delete | cmd vm delete update parameter no_wait: added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| vm delete | cmd vm delete update parameter no_wait: added property nargs=? |
||
| vm delete | cmd vm delete update parameter no_wait: added property type=bool |
||
| vm delete | cmd vm delete update parameter resource_group_name: added property aaz_type=string |
||
| vm delete | cmd vm delete update parameter resource_group_name: added property type=string |
||
| vm delete | cmd vm delete update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| vm delete | cmd vm delete update parameter vm_name: added property aaz_type=string |
||
| vm delete | cmd vm delete update parameter vm_name: added property type=string |
||
| vm delete | cmd vm delete update parameter vm_name: updated property name from vm_name to name |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates several Azure VM commands to a CodeGen-based implementation using the AAZ framework, replacing manual SDK calls with generated command classes and updating schema types.
- Introduces a new
VMCaptureclass inoperations/vm.pyto handlevm captureoutput and registers it in the command table. - Refactors
create_vm,get_instance_view,get_vm_details, andlist_vmincustom.pyto use dictionary-style access and AAZ command invocations. - Updates AAZ schemas in
_update.pyand_show.pyto replaceAAZFreeFormDictTypewithAAZDictTypeand define element types, and adds generated code for delete and capture in the AAZ folder.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/operations/vm.py | Added VMCapture class and import for CodeGen-based capture. |
| src/azure-cli/azure/cli/command_modules/vm/custom.py | Refactored identity handling, get_instance_view, and listing. |
| src/azure-cli/azure/cli/command_modules/vm/commands.py | Registered vm capture command via command_table. |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vm/* | Updated schemas (_update.py, _show.py), added _delete.py, _capture.py, and adjusted __init__.py. |
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/vm/custom.py:1376
- [nitpick] The variable name
filtershadows the built-infilter()function. Consider renaming it tofilter_exprorfilter_strto avoid confusion.
filter = "'virtualMachineScaleSet/id' eq '{}'".format(vmss)
zhoxing-ms
approved these changes
Jun 17, 2025
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vm capture/delete/get-instance-view/listDescription
Migrate commands to CodeGen based
aaz PR: Azure/aaz#783
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.