Conversation
added 2 commits
June 16, 2025 13:57
…ssage for PG 11 and 13
️✔️AzureCLI-FullTest
|
|
Hi @mattboentoro, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds end-of-life notifications for PostgreSQL versions 11, 12, and 13 in the flexible-server commands, preventing selection of unsupported versions and warning about upcoming EOL.
- Adds CLIErrors for PG 11 & 12 in
_pg_version_validator - Updates PG 12 recommendation to point to version 14
- Adds warnings for PG 13 EOL in both validator and upgrade flow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/rdbms/validators.py | Added errors for PostgreSQL 11/12 end-of-life and warning for PG 13 |
| src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_common.py | Added warning for PostgreSQL 13 end-of-life in version upgrade logic |
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/rdbms/validators.py:517
- Consider adding unit tests to cover the new end-of-life error and warning messages for PostgreSQL versions 11, 12, and 13 in the
_pg_version_validatorfunction.
if version == '11':
src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_common.py:306
- [nitpick] To maintain consistency with the validator behavior, consider adding a warning for PostgreSQL version 12 since it has also reached end-of-life.
if version == '13':
nasc17
reviewed
Jun 17, 2025
| if version: | ||
| if version not in versions: | ||
| raise CLIError('Incorrect value for --version. Allowed values : {}'.format(sorted(versions))) | ||
| if version == '11': |
Member
There was a problem hiding this comment.
Nit this could be check for 11 and 12 together
nasc17
approved these changes
Jun 17, 2025
Member
Author
|
@evelyn-ys do you mind reviewing this PR? |
evelyn-ys
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az postgres flexible-server create
az postgres flexible-server update
az postgres flexible-server upgrade
Description
Add eol message for PG 11 and 13
Testing Guide
Manual testing
History Notes
{RDBMS}
az postgres flexible-server create/update/upgrade: Add eol message for PG 11 and 13This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.